Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃挕 RFC: EditorConfig compatibility #729

Open
3 tasks
cdtut opened this issue Dec 19, 2023 · 1 comment
Open
3 tasks

馃挕 RFC: EditorConfig compatibility #729

cdtut opened this issue Dec 19, 2023 · 1 comment
Labels
needs triage Issue needs to be triaged

Comments

@cdtut
Copy link

cdtut commented Dec 19, 2023

Background & Motivation

EditorConfig is very convenient standard for setting indent style and to trim trailing whitespace to do minimal formatting during saving. It is also standard that work in lots of editors.

Can new setting be added to disable prettier formatting? Only way to disable it is disable all formatting. But then have to spend lots of time changing indent and trim trailing whitespace in manual way because no formatting is possible.

If new setting is there then it is possible to disable prettier but EditorConfig extension can still do its useful formatting which helps a lot.

Proposed Solution

Possible solutions

New setting to disable prettier in astro files but compatible with EditorConfig settings.

Detailed Design

No response

Help make it happen!

  • I am willing to submit a PR to implement this change.
  • I am willing to submit a PR to implement this change, but would need some guidance.
  • I am not willing to submit a PR to implement this change.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Dec 19, 2023
@rogama25
Copy link

A similar thing happens to me, I want to keep my indentations to 2 spaces but the Astro plugin keeps formatting it to 4 spaces. Seems to ignore the tab_width setting even though Prettier documentation explicitly says that is supported here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants