AstroJSX syntax [WIP] #828
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was
linked to
issues
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Astro expression syntax is similar to JSX, but it's not JSX. So, we need to create a new syntax for it, including the JSX syntax as a base, and adding some Astro-specific patterns over it.
This will allow us to fix some issues much more easily, such as #708 or #714 . Also, the syntax will match the actual behaviour of Astro expressions, like basic HTML comments - not supported by JSX in expressions, but Astro does.
Testing
Will be tested. I swear.
Docs
N/A, this PR will make the syntax match the actual behaviour of Astro expressions. But the code is commented.