Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 BUG: Other projects prompt astro refactoring #666

Open
recallwei opened this issue Oct 13, 2023 · 2 comments
Open

馃悰 BUG: Other projects prompt astro refactoring #666

recallwei opened this issue Oct 13, 2023 · 2 comments
Labels
- P3: minor bug An edge case that only affects very specific usage (priority) ecosystem: upstream Issue is caused by a bug / missing feature upstream

Comments

@recallwei
Copy link

Describe the Bug

When I work on other projects, even non-Astro projects, the Astro plugin will prompt for refactoring. Can I disable this behavior or prompt for refactoring only when the project contains astro dependencies?

Steps to Reproduce

  1. enable astro VSCode extension
  2. open a React or Vue project
  3. try to change the location of the component which imported into the page
  4. the Astro extension prompt that should you refactor.
@recallwei
Copy link
Author

recallwei commented Oct 31, 2023

First:
Astro Extension wants to refactor changes by moving this file
image
Then:
Whether to update the import of footer.tsx
image
Even though I'm not working on the Astro project.
I had to check twice.

@Princesseuh Princesseuh added the needs triage Issue needs to be triaged label Nov 13, 2023
@Princesseuh
Copy link
Member

Hmm, this is most likely coming from our TypeScript plugin being always enabled, I'd assume. Not too sure if it's because of a misconfiguration, or if we should just disable the plugin when it's not an Astro project (which, in the past, when we used to do that, caused a lot of issues)

@Princesseuh Princesseuh added ecosystem: upstream Issue is caused by a bug / missing feature upstream - P3: minor bug An edge case that only affects very specific usage (priority) and removed needs triage Issue needs to be triaged labels Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P3: minor bug An edge case that only affects very specific usage (priority) ecosystem: upstream Issue is caused by a bug / missing feature upstream
Projects
None yet
Development

No branches or pull requests

2 participants