-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
(en) github.mdx
: The description of the text is discrepancy.
#10868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Great catch! The code example was updated, but not the text describing the proper use of I would happily accept a PR from someone who carefully goes through a deploy and checks whether in fact the slash is necessary, whether both work, and then makes updates throughout the page to text instructions/explanations as necessary. In particular, the advice to update all your links Adding |
Hi everyone, Test Setup:
Configurations Tested:
Results for BOTH configurations were identical:
So:
I'll open a PR shortly with proposed changes to (Side note: I also encountered an issue where the |
It doesn't completely answer the question. In #7481 @ben-milanko found the leading slash causes links under |
I can't remember the exact conditions around the original issue I had with the base path, but I have run into the issue with leading underscore files not loading on GitHub pages. I found this post which explains it is due to GitHub's Jekyll processing. After using their suggested fix everything worked correctly. It would probably be good to include this in the docs for deployments to GitHub pages. |
Uh oh!
There was an error while loading. Please reload this page.
📚 Subject area/topic
guides/deploy
📋 Page(s) affected (or suggested, for new content)
https://docs.astro.build/en/guides/deploy/github/
📋 Description of content that is out-of-date or incorrect
The leading slash in the value of the base parameter is being removed by #7481.
However, the text explains that the base parameter value must be prefixed with slash.
Incidentally, when I tried deploying with GitHub Pages, I was able to deploy successfully with or without the slash. What exactly was the problem with #7481? And please think of a way to resolve this discrepancy.
NOTE: Or rather, there are several inaccurate statements in addition to the points pointed out above. You may want to carefully verify that the entire text is correct.
🖥️ Reproduction in StackBlitz (if reporting incorrect content or code samples)
No response
The text was updated successfully, but these errors were encountered: