Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query about ALI_BIGAN #59

Open
devraj89 opened this issue Jun 13, 2018 · 1 comment
Open

query about ALI_BIGAN #59

devraj89 opened this issue Jun 13, 2018 · 1 comment

Comments

@devraj89
Copy link

devraj89 commented Jun 13, 2018

Hi
Thanks for your wonderful code! I was looking through the code for Bidirectional GAN and have a few doubts :
[1] In the discriminator step why is Line 83 required ? Is it required to update the generator during discriminator learning ? should not it be fixed ?
Is this a G_solver.step() needed ?

[2] while updating the generator(Q and P), are you using the the inverse objective function found in Appendix 2 page 16 here at https://arxiv.org/pdf/1605.09782.pdf ?
otherwise should not it be a minimization problem and the - sign in Line 93 not required ?

[3] also why is the final layer in the generator a sigmoid layer ?

Thanks in advance ! I will be grateful to hear anything on this matter.

@wiseodd
Copy link
Owner

wiseodd commented Jun 15, 2018

Hi,

I used ALI paper (https://arxiv.org/pdf/1606.00704.pdf) as reference for this code.
You might want to check Algorithm 1 in page 3 there.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants