Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podAnnotations is incorrectly passed to deployment #53

Open
lkoniecz opened this issue Mar 12, 2025 · 0 comments
Open

podAnnotations is incorrectly passed to deployment #53

lkoniecz opened this issue Mar 12, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@lkoniecz
Copy link

lkoniecz commented Mar 12, 2025

Proposal

Add removal of all leading and trailing whitespace, including newlines via {{- -}} here https://github.com/wiremock/helm-charts/blob/master/charts/wiremock/templates/_helpers.tpl#L71 and parse with toYaml

{{- toYaml .Values.podAnnotations | nindent 0 -}}

othewise the tenplate is not rendered when podAnnotation is provided

Reproduction steps

add

podAnnotations:
  aa: bb

to values.yaml, fire

❯ helm template .      
Error: YAML parse error on wiremock/templates/deployment.yaml: error converting YAML to JSON: yaml: line 23: could not find expected ':'

Use --debug flag to render out invalid YAML

References

No response

@lkoniecz lkoniecz added the bug Something isn't working label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant