Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AndroidTwitterLogin #8

Open
brandall76 opened this issue Aug 28, 2013 · 0 comments
Open

AndroidTwitterLogin #8

brandall76 opened this issue Aug 28, 2013 · 0 comments

Comments

@brandall76
Copy link

onPageStarted is called twice. I haven't identified why - It could be an Android OS/device specific for the handling of the WebView.

The first received url is correct, the second is logged as someurl.com/mf.php - therefore verifier == null and onFail is subsequently called

Suggest adding to line 92:

if ( ! url.contains(callbackUrl)) return;

to become:

if ( ! url.contains(callbackUrl) && ! url.endsWith("mf.php")) return;

Or if this is too specific, prevent onFail being called if onSuccess has already been called:

if ( ! url.contains(callbackUrl) && ! success) return;

Where:

boolean success = false;

Is placed inside run() and set to true prior to line 106:

dialog.dismiss();
onSuccess(jtwitter, tokens);

Email me if you need any more info.

Cheers

Ben

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant