Add support for category filtering in Categories component #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennothommo
requested changes
Sep 12, 2022
Comment on lines
+56
to
+61
| 'categoryFilter' => [ | ||
| 'title' => 'winter.blog::lang.settings.posts_filter', | ||
| 'description' => 'winter.blog::lang.settings.posts_filter_description', | ||
| 'default' => '{{ :slug }}', | ||
| 'type' => 'string', | ||
| ], |
There was a problem hiding this comment.
@RomainMazB three comments here:
- I think the name
categoryFilteris probably not accurate for what we are doing. Instead, this should probably berootCategory, as technically we are specifying a root category to start nesting from. - I think those lang strings might be incorrect?
- Should the default perhaps be blank so that the original functionality is maintained?
bennothommo
reviewed
Sep 12, 2022
| $categoriesQuery->where('slug', $slug); | ||
| } | ||
|
|
||
| $categories = $categoriesQuery->first()->getChildren(); |
There was a problem hiding this comment.
@RomainMazB I'd recommend we continue nesting with getNested here, and leave it up to the template whether to display the full nested structure underneath the root category, or just simply show the direct children.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #26