Winter CMS 1.2 is now available for general testing

[bennothommo]

The 1.2 branch of Winter is now available for general testing! Built on top of Laravel 9, it supports PHP 8.0 and 8.1, and includes better support for Tailwind, Font Awesome 6, command autocompletion and a whole heap of performance tweaks and code cleanup, making this the most streamlined release of Winter yet!

Check out the blog announcement and have a read of the upgrade guide!

[fosterushka]

Huzzah 🎉🥳

[Artful-dodger]

Just reading the blurb on this release and was wondering how you scaffold a tailwindcss project as one of the bullet point suggests. Is there a spercific command for this?

[Artful-dodger]

looks like this is not compatible with wamp because pcntl extension is required and is not compatible with windows, I discovered this when trying php artisan mix:watch theme-tailwind gives an error of Undefined constant "System\Console\SIGINT"

[LukeTowers]

Can you submit an issue for that @Artful-dodger?

Reading up on https://stackoverflow.com/a/37464124, https://www.reddit.com/r/PHP/comments/aavqes/its_impossible_in_php_to_handle_ctrlc_on_windows/, https://bugs.php.net/bug.php?id=77365, & https://www.php.net/manual/en/function.sapi-windows-set-ctrl-handler.php I think our best option is to implement the script termination logic in as cross platform as a way as we can in the base Winter\Storm\Console\Command class (or via a trait) and call a method when defined on the command class being processed when a user termination signal is sent and then switch the watch command to use that instead. @bennothommo @jaxwilko any thoughts?

[Artful-dodger]

I have tried to run this command "php artisan create:theme mytheme tailwind" on ubuntu 22.04 server and get the following error "file does not exist at path /var/www/html/modules/cms/console/scaffold/theme/tailwind/readme.stub" but when I check the stub file does exist not sure what is causing this error but the command does not complete

[Artful-dodger]

from what I have notice the error is caused by the stub file name being in capital letters and being called in lower case letters ie the file is README.stub but the script is looking for readme.stub not sure if this is just affected in ubuntu 22/04

[LukeTowers]

@Artful-dodger the issue is fixed on the develop branch

[Artful-dodger]

This morning just going to try the Installer file I have just downloaded see if that has any effect Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows From: Ben ***@***.***> Sent: 18 May 2022 13:36 To: ***@***.***> Cc: ***@***.***>; ***@***.***> Subject: Re: [wintercms/winter] Winter CMS 1.2 is now available for general testing (Discussion #558) Yeah it looks like you're running 1.2, but when did you do the upgrade? — Reply to this email directly, view it on GitHub<#558 (reply in thread)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AC2XAHCZEZ7PCRMXRGOBVDLVKTP57ANCNFSM5WDJMEYQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[LukeTowers]

The problem is in the path generation logic within the Mix command classes, you would need to do some debugging on them to figure out why it's treating an absolute path (C:\wamp64\www\winter1-2\themes\test) as a relative path (since it's adding it to the application base path of C:\wamp64\www\winter1-2). It's an issue only for Windows users because of the difference in how paths are handled between Unix systems and Windows. Unfortunately, none of the core team develops with Windows machines actively so it's not easy for us to find and solve those issues so your best chance at getting it solved is to step through the code for the System\Console\MixCompileCommand class yourself and figure out where it's getting confused and then update us on your findings or submit a PR.

[Artful-dodger]

Thank you Luke I will do this over the week end

[Artful-dodger]

I had a bit of spare time and found where the error is accuring its line 114
/**
* Get the path to the mix.webpack.js file for the provided winter.mix.js file
*/
protected function getWebpackJsPath(string $mixJsPath): string
{
return $this->getPackagePath($mixJsPath) . '/mix.webpack.js';
}
not sure yet how to fix but this is where the duplicate path comes from

[LukeTowers]

@Artful-dodger if you could also submit this as a separate issue that would be helpful.

[Dreanad]

Hey there, its from the MixCompile.php file on line 94, the base_path() method add the duplication of C:\
because the base_path function doesnt exist, its returning the absolut path of the app ( helpers from laravel)

i dont know how to resolve this properly, hope that can help i will try on a linux distribution and my windows to find a solution

[Artful-dodger]

Hi Louis, Not sure the cause of the problem as yet as I have installed Laravel-mix on wamp as a stand alone project and it works fine I am going to reinstall the tailwind theme again and see if I can get it to work with configuration I have setup within wintercms 1.2 let you know how I get on also there is an issue with the watch command not sure if they are both linked Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows

…

________________________________ From: Louis-Etienne Leuilliot ***@***.***> Sent: Saturday, May 28, 2022 5:23:43 PM To: wintercms/winter ***@***.***> Cc: Artful-dodger ***@***.***>; Mention ***@***.***> Subject: Re: [wintercms/winter] Winter CMS 1.2 is now available for general testing (Discussion #558) Hey there, its from the MixCompile.php file on line 94, the base_path() method add the duplication of C:\ because the base_path function doesnt exist, its returning the absolut path of the app ( helpers from laravel) i dont know how to resolve this properly, hope that can help i will try on a linux distribution and my windows to find a solution — Reply to this email directly, view it on GitHub<#558 (reply in thread)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AC2XAHCVAVIKYWR2RJRFI7DVMJCA7ANCNFSM5WDJMEYQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[ivang76]

Hi there,
I'm trying to update and test this new version on a running winter project, already migrated from october some months ago, but when I run the composer update I get this error:

In WebDAVAdapter.php line 18:
    Class "League\Flysystem\Adapter\AbstractAdapter" not found   

In the upgrade guide I read that "The Rackspace Flysystem driver / adapter is no longer supported", ok, but then what I should do to fix this error? I'm gonna to follow this one: https://laravel.com/docs/9.x/upgrade#flysystem-3

Thanks!

[ivang76]

ok I solved simply adding this:
composer require league/flysystem-webdav:^3.0

and then, depending by the needs:

Amazon S3: composer require -W league/flysystem-aws-s3-v3 "^3.0"
FTP: composer require league/flysystem-ftp "^3.0"
SFTP: composer require league/flysystem-sftp-v3 "^3.0"

[ivang76]

Now I have another problem... all the pages (created with Pages or with the CMS section) are going to 404 in both the two activated languages.
There are no problems with the routes related to the backend.
Any ideas on what to check or debug?

If I disable the second language (but I would need at least two of them), it seems that something is working on the home page, but opening a page I get this error:
Too few arguments to function Twig\Environment::loadTemplate(), 1 passed in /../.../testing_L9/plugins/winter/pages/classes/Controller.php on line 79 and at least 2 expected

On the upgrade guide I read that "The signature for $twig->loadTemplate() has been changed, use $twig->load() instead." but should not be it already fixed in the plugin itself? (I already installed the latest version of twig)

[bennothommo]

Not until our own marketplace is live. It's probably good practice to get used to Composer though :)

[ivang76]

yes indeed... ok thanks, now that twig error is fixed, but if I re-add the second language, all the routes go in 404.
Maybe I have to update also the translate plugin via composer?

[bennothommo]

Yes, you will need to use "winter/wn-translate-plugin": "dev-wip/1.2" as well.

[LukeTowers]

@ivang76 Yes, see wintercms/wn-translate-plugin@a1e8ef7. Switch the translate plugin to the same dev-wip/1.2

[ivang76]

ok great, it works, thanks!

[ivang76]

I get again the abstract adapter error during the testing of winter 1.2, on another old plugin that I use from the old "october" times... it's the backup by Panagiotis https://github.com/panakour/oc-backup-plugin)

Class "League\Flysystem\Adapter\AbstractAdapter" not found
/Applications/MAMP/htdocs/Institutes_L9/plugins/panakour/backup/vendor/spatie/flysystem-dropbox/src/DropboxAdapter.php line 12

did maybe someone encountered and solved already this problem? or do you know if there is another similar plugin winter-laravel9 ready?

[ivang76]

@LukeTowers I have done in that way, but I still have this "orphan" static pages no more linked to the web app, no listed in the backend and without my custom main menu.
(thanks damsfx, useful indeed... but in this moment my problem is to migrate the old versione of those plugins without lose data)

[LukeTowers]

@ivang76 sounds like something else is going wrong, the Winter.Pages plugin should just work with your existing RainLab data, there's no namespacing on the data itself that would prevent it from working. Can you send me your theme where the files are present but unable to be detected by Winter.Pages?

[damsfx]

Why would you do that? Just remove the rainlab plugins from your project once, shouldn't need to continually remove them.

Just because some plugins got Rainlab User/Location/Page plugins in their package.json dependencies.
Every time you run composer u they are reinstalled and then results in an issue if you run php artisan winter:up directly after.

[LukeTowers]

Gotcha. That should be fixed by adding replace definitions to the Winter plugin composer.json files.

[ivang76]

@ivang76 sounds like something else is going wrong, the Winter.Pages plugin should just work with your existing RainLab data, there's no namespacing on the data itself that would prevent it from working. Can you send me your theme where the files are present but unable to be detected by Winter.Pages?

thanks, I'll try to investigate and debug deeper then... some references or files are deleted during the upgrading, maybe when I run the composer... I can't share the theme because contains private pages of my client sorry.

[Artful-dodger]

I not sure if there is an error in the setup for "php artisan create:theme [theme name] tailwind" in ubuntu 22.04 but the script fails at the readme.stub section because the file name is README.stub but the script is looking for readme.stub

[LukeTowers]

It's fixed on develop