Skip to content

Commit 09a7a88

Browse files
jaxwilkomjauvin
andauthored
Apply suggestions from code review
Co-authored-by: Marc Jauvin <[email protected]>
1 parent 1120f01 commit 09a7a88

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

modules/system/classes/extensions/ModuleManager.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ public function update(WinterExtension|string|null $extension = null, bool $migr
118118

119119
$versions
120120
? $this->renderComponent(Info::class, sprintf('Updated module %s (%s) from v%s => v%s', $module, $composerPackage, $versions[0], $versions[1]))
121-
: $this->renderComponent(Error::class, sprintf('Failed to module %s (%s)', $module, $composerPackage));
121+
: $this->renderComponent(Error::class, sprintf('Failed to update module %s (%s)', $module, $composerPackage));
122122
} elseif (false /* Detect if market */) {
123123
Preserver::instance()->store($extension);
124124
// @TODO: Update files from market

modules/system/classes/extensions/PluginManager.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1496,7 +1496,7 @@ public function deletePlugin(string $id): void
14961496
* Disables the provided plugin using the provided flag (defaults to static::DISABLED_BY_USER)
14971497
* @deprecated
14981498
*/
1499-
public function disablePlugin(PluginBase|string $plugin, string|bool $flag = self::DISABLED_BY_USER): bool
1499+
public function disablePlugin(PluginBase|string $plugin, string|bool $flag = self::DISABLED_BY_USER): ?bool
15001500
{
15011501
return $this->disable($plugin, $flag);
15021502
}
@@ -1505,7 +1505,7 @@ public function disablePlugin(PluginBase|string $plugin, string|bool $flag = sel
15051505
* Enables the provided plugin using the provided flag (defaults to static::DISABLED_BY_USER)
15061506
* @deprecated
15071507
*/
1508-
public function enablePlugin(PluginBase|string $plugin, $flag = self::DISABLED_BY_USER): bool
1508+
public function enablePlugin(PluginBase|string $plugin, $flag = self::DISABLED_BY_USER): ?bool
15091509
{
15101510
return $this->enable($plugin, $flag);
15111511
}

0 commit comments

Comments
 (0)