Apply suggestions from code review

Co-authored-by: Marc Jauvin <[email protected]>
wintercms · Jan 5, 2025 · 09a7a88 · 09a7a88
1 parent 1120f01
commit 09a7a88
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/modules/system/classes/extensions/ModuleManager.php b/modules/system/classes/extensions/ModuleManager.php
@@ -118,7 +118,7 @@ public function update(WinterExtension|string|null $extension = null, bool $migr
 
                     $versions
                         ? $this->renderComponent(Info::class, sprintf('Updated module %s (%s) from v%s => v%s', $module, $composerPackage, $versions[0], $versions[1]))
-                        : $this->renderComponent(Error::class, sprintf('Failed to module %s (%s)', $module, $composerPackage));
+                        : $this->renderComponent(Error::class, sprintf('Failed to update module %s (%s)', $module, $composerPackage));
                 } elseif (false /* Detect if market */) {
                     Preserver::instance()->store($extension);
                     // @TODO: Update files from market

diff --git a/modules/system/classes/extensions/PluginManager.php b/modules/system/classes/extensions/PluginManager.php
@@ -1496,7 +1496,7 @@ public function deletePlugin(string $id): void
      * Disables the provided plugin using the provided flag (defaults to static::DISABLED_BY_USER)
      * @deprecated
      */
-    public function disablePlugin(PluginBase|string $plugin, string|bool $flag = self::DISABLED_BY_USER): bool
+    public function disablePlugin(PluginBase|string $plugin, string|bool $flag = self::DISABLED_BY_USER): ?bool
     {
         return $this->disable($plugin, $flag);
     }
@@ -1505,7 +1505,7 @@ public function disablePlugin(PluginBase|string $plugin, string|bool $flag = sel
      * Enables the provided plugin using the provided flag (defaults to static::DISABLED_BY_USER)
      * @deprecated
      */
-    public function enablePlugin(PluginBase|string $plugin, $flag = self::DISABLED_BY_USER): bool
+    public function enablePlugin(PluginBase|string $plugin, $flag = self::DISABLED_BY_USER): ?bool
     {
         return $this->enable($plugin, $flag);
     }