Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intellisense doesn't trigger for multi-line functions #54

Open
phoenisx opened this issue Aug 5, 2022 · 1 comment
Open

Intellisense doesn't trigger for multi-line functions #54

phoenisx opened this issue Aug 5, 2022 · 1 comment
Assignees
Labels
bug Something isn't working non-critical Issues that can be deferred
Milestone

Comments

@phoenisx
Copy link
Contributor

phoenisx commented Aug 5, 2022

multiline-issue.mp4
@phoenisx phoenisx added bug Something isn't working non-critical Issues that can be deferred labels Aug 11, 2022
@phoenisx phoenisx added this to the 2.3.1 milestone Aug 28, 2022
@phoenisx phoenisx self-assigned this Aug 28, 2022
@phoenisx phoenisx removed this from the 2.3.1 milestone Sep 6, 2022
@phoenisx phoenisx modified the milestone: 2.3.2 Sep 16, 2022
@phoenisx phoenisx mentioned this issue Nov 1, 2022
8 tasks
@phoenisx phoenisx added this to the v3.0 milestone Nov 1, 2022
@phoenisx
Copy link
Contributor Author

Some learnings from here: microsoft/vscode#99504, though not helpful for this plugin to get triggered only when required.

Some pointers I need to keep in mind:

  • VSCode autocomplete triggers plugins registered for completion with special characters like - a lot of times.
  • If we return an empty list: [], autocomplete will not get triggered unless autocomplete popup closes and user presses our trigger character again.
  • We need to backtrack characters and find out if for the current trigger we need to show completion items or not intelligently, without affecting user's usual development, and bombarding with suggestions on any random trigger character press.

I haven't tried using LSP, but with above findings, I don't think there would be any difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-critical Issues that can be deferred
Projects
None yet
Development

No branches or pull requests

1 participant