Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] color swatch for propagated properties has invisible text #113

Open
T3sT3ro opened this issue Nov 12, 2023 · 3 comments
Open

[Bug] color swatch for propagated properties has invisible text #113

T3sT3ro opened this issue Nov 12, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@T3sT3ro
Copy link

T3sT3ro commented Nov 12, 2023

Describe the bug
I declare the following properties

--a: red;
--b: var(--a);

When the color widget is clicked on --a it shows the text in the header with color info, but when clicked on --b it shows invisible text in the header (it's not interactive, but hovering over there shows tooltips).

To Reproduce
Steps to reproduce the behavior:

  1. Create file with the snippet above
  2. click on the color swatch next to --b property

Expected behavior
the header of the widget should show name of the color and should be interactive

Screenshots
image

Details (please complete the following information):

  • OS: Linux
  • VSCode version: 1.84.2
  • Extension version: 2.6.4
@T3sT3ro T3sT3ro added the bug Something isn't working label Nov 12, 2023
@phoenisx
Copy link
Contributor

phoenisx commented Nov 16, 2023

Hi @T3sT3ro

Thanks for raising the issue.
Is there any specific need for showing the color label in the popup?
I intentionally removed this feature a long time ago, since showing a label makes the highlighted range editable when clicking on the popup's colour label.
Since var() is already dynamic and shows details of the color in the color swatch, it felt enough and disabling color label in the popup made the var() uneditable from color popup.


What I am trying to say is supporting your feature makes the CSS var editable from the Color Popup, as shown in below screen recording:

out.mp4

@phoenisx phoenisx reopened this Nov 16, 2023
@T3sT3ro
Copy link
Author

T3sT3ro commented Nov 16, 2023

I noticed it when I wanted to copy the hsl value for some testing and I thought the whole picker is broken until had a hunch to follow the chain to the top. I think the use cases for that aren't common, but sometimes it was just useful to see the values when still working on the colors.

Editability in this place would indeed be an unwanted effect, but sometimes seeing the value could be valuable (pun not intended)

@phoenisx
Copy link
Contributor

phoenisx commented Nov 16, 2023

I'll keep this issue open, in case there are more demands for this feature.
As of now, I'll keep this on hold, till I or someone else get time to work on this. 👍🏽

NOTE: This looks like a breaking feature, though no user flows will be directly affected. Only if someone clicks on the color popup title will this cause an unexpected result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants