Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group.toBound
's return type was wrongly markedGroup
. ClosesGroup.toBound
's return type wrongly marked asGroup
#214Bound
stores top left and bottom rightPt
s separately. Close Bound's bottom right pt isn't updated after calling e.g.add
#213For 2, top left and bottom right
Pt
s were separate fromPt
s that are indexable using integers.This causes that, when a calculation method such as
add
inherited fromGroup
is used on aBound
, theBound
's cornerPts
s are sometimes not updated, asGroup
uses integer indices for getting the memberPt
s.In order to fix this, the separate members
_topLeft
and_bottomRight
are removed fromBound
.topLeft
andbottomRight
are now just getters for integer-indexablePt
s.