Fix problems with Bound
#215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. `Group.toBound`'s return type was wrongly marked `Group`. Closes williamngan#214 2. `Bound` stores top left and bottom right `Pt`s separately. Close williamngan#213 For 2, top left and bottom right `Pt`s were separate from `Pt`s that are indexable using integers. This causes that, when a calculation method such as `add` inherited from `Group` is used on a `Bound`, the `Bound`'s corner `Pts`s are sometimes not updated, as `Group` uses integer indices for getting the member `Pt`s. In order to fix this, the separate members `_topLeft` and `_bottomRight` are removed from `Bound`. `topLeft` and `bottomRight` are now just getters for integer-indexable `Pt`s.
✅ Deploy Preview for astronaut-horse-32874 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@ii41 - Thank you so much for catching this bug and providing such a great fix too. Really appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group.toBound's return type was wrongly markedGroup. ClosesGroup.toBound's return type wrongly marked asGroup#214Boundstores top left and bottom rightPts separately. Close Bound's bottom right pt isn't updated after calling e.g.add#213For 2, top left and bottom right
Pts were separate fromPts that are indexable using integers.This causes that, when a calculation method such as
addinherited fromGroupis used on aBound, theBound's cornerPtss are sometimes not updated, asGroupuses integer indices for getting the memberPts.In order to fix this, the separate members
_topLeftand_bottomRightare removed fromBound.topLeftandbottomRightare now just getters for integer-indexablePts.