Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add-ons: Prevent uploading of specific files #6326

Open
3 tasks
bunnybot opened this issue Jan 24, 2024 · 2 comments · May be fixed by #6417
Open
3 tasks

Add-ons: Prevent uploading of specific files #6326

bunnybot opened this issue Jan 24, 2024 · 2 comments · May be fixed by #6417
Assignees
@bunnybot
Labels
addon Problems and requests related to add-ons enhancement New feature or request
Milestone
v1.3

Comments

@bunnybot
Copy link

bunnybot commented Jan 24, 2024 •
edited

frankystoneMirrored from Codeberg
Created on Wed Jan 24 10:03:51 CET 2024 by frankystone

AFAIK uploading an add-on will upload all files inside the *.wad directory including hidden files. If someone uses e.g. git to work on an addon the hidden folder .git will also be transferred.
Sometimes a texteditor creates also a hidden file when editing files. Although those files will be removed after closing the texteditor they remain under some circumstances.

Describe the solution you'd like
Uploading should prevent uploading of hidden files and folders.

Describe alternatives you've considered
In the forum the suggestion was made to create something like a .wl-ignore file which acts similar to .git-ignore. I think this is not needed and preventing uploading hidden files would be sufficient.

Implementation steps

  • ...
  • ...
  • ...
@bunnybot bunnybot added enhancement New feature or request addon Problems and requests related to add-ons labels Jan 24, 2024
@bunnybot
Copy link
Author

knarrffMirrored from Codeberg
On Wed Jan 24 23:08:31 CET 2024, Frank Löffler (knarrff) wrote:

I agree with removing directories like .git in general from an upload - but for people that already use git and quite likely use one of the publicly reachable places like codeberg or gitlab or github: couldn't widelands also allow an upload by something like a pull request? If a real pull request to, say an add-ons repo is not possible, what about only uploading the URL and hash for a specific version of a repo and the rest can be handled by widelands? This would also likely simplify review of changes to add-ons, because tracking changes is a lot easier when a version control system is used, I think.

@bunnybot bunnybot added this to the v1.3 milestone Mar 23, 2024
@bunnybot bunnybot self-assigned this Mar 23, 2024
@bunnybot
Copy link
Author

Assigned to Nordfriese

@bunnybot bunnybot linked a pull request Mar 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bunnybot bunnybot

Labels
addon Problems and requests related to add-ons enhancement New feature or request
Projects
None yet
Milestone
v1.3
Development

Successfully merging a pull request may close this issue.

Ignore hidden files when uploading add-on widelands/widelands
1 participant
@bunnybot