Remaining Clang-Tidy Checks #5262
Replies: 4 comments 2 replies
-
@Noordfrees Do I understand this correct that this list is based on the warnings thrown by our current code? Sorry for posing so many questions, but I just want to understand what we are doing here. |
Beta Was this translation helpful? Give feedback.
-
Well from my professional life I am used to first define a coding standard for a project and afterwards enforcing it with a sufficient tool. I can adopt to choose the tool and then enforce the checks it provides. each other check would be sensible to activate imho. |
Beta Was this translation helpful? Give feedback.
-
I can't comment on which tests to include or exclude, but when the list is finalised, please create a Also currently I'll still venture a question regarding @Noordfrees's perm-suppressed list: These look quite scary, and I think they're only used in a few critical places. Shouldn't the critical parts get overrides instead of ignoring the checks completely? |
Beta Was this translation helpful? Give feedback.
-
well the list is not up to date maybe we could date it up Edit: cleaned up and updated the list |
Beta Was this translation helpful? Give feedback.
-
Following the discussion in #5246, I've made a list of checks that are not yet being enforced by our clang-tidy CI. I've categorized them as:
This categorization reflects my personal opinion and is open for discussion.
Perm-suppressed checks
Improves performance
Helps against bugs
Possibly useful style stuff
Undesired nonsense
Beta Was this translation helpful? Give feedback.
All reactions