Replace error with reason in "abort a NavigateEvent"
#11967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The input parameter is named `reason`, not `error` which it used to be named before this algorithm was extracted from "abort the ongoing navigation".
annevk
approved these changes
Nov 27, 2025
Collaborator
LGTM |
AtkinsSJ
added a commit
to AtkinsSJ/ladybird
that referenced
this pull request
Nov 27, 2025
I missed where this change happened in the spec. The second half of abort_the_ongoing_navigation() becomes a separate method, which is slightly rearranged. I've placed this in Navigation instead of NavigateEvent because of how many steps poke at the Navigation's internals. The text here includes the amendments I made in whatwg/html#11967 to correct a variable name. A bonus is that we now actually populate the ErrorEvent instead of leaving it blank.
AtkinsSJ
added a commit
to AtkinsSJ/ladybird
that referenced
this pull request
Nov 27, 2025
I missed where this change happened in the spec. The second half of abort_the_ongoing_navigation() becomes a separate method, which is slightly rearranged. I've placed this in Navigation instead of NavigateEvent because of how many steps poke at the Navigation's internals. The text here includes the amendments I made in whatwg/html#11967 to correct a variable name. A bonus is that we now actually populate the ErrorEvent instead of leaving it blank.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input parameter is named
reason, noterrorwhich it used to be named before this algorithm was extracted from "abort the ongoing navigation".Fixes #11966.
(Skipping the checklist as this is a simple editorial error.)
/nav-history-apis.html ( diff )