Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of muscles in MuscleWidget #422

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thisisyoussef
Copy link

@thisisyoussef thisisyoussef commented Aug 19, 2023

Ensure that when a muscle is both main and secondary, only the main muscle background is drawn. This addresses potential overlaps and redundant rendering in the MuscleWidget.

Proposed Changes

-Updated the build method in MuscleWidget to filter out secondary muscles that are also present in the main muscles list before rendering.
-By doing so, we prevent the same muscle from being rendered twice, ensuring that only the main muscle background is displayed.
-This approach retains the structure and readability of the code while addressing the issue.

Please check that the PR fulfills these requirements

  • Set a 100 character limit in your editor/IDE to avoid white space diffs in the PR
  • Tests for the changes have been added (for bug fixes / features)
  • Added yourself to AUTHORS.md

Ensure that when a muscle is both main and secondary, only the main muscle background is drawn. This addresses potential overlaps and redundant rendering in the MuscleWidget.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant