-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Data Ajax - Plugin calls wb.init forever #9198
Comments
* Fixes wet-boew#9198 * Partially-reverts wet-boew#6076
@EricDunsworth please re-test. The recent patches to jQuery has impacted the data-ajax plugin. Also, I noticed the wet-boew is looking periodically, via the timepoke, if there any new data-ajax plugin added on the page. May be the issue you are describing is related to that behaviour. May be instead of using timepoke it might worth to explore the experimental CSS animation solution here: https://github.com/wet-boew/wet-boew-experimental/blob/master/src/wet-boew.js#L49 |
Just retried the OP's reproduction steps in the |
Required information
Describe the bug
I've noticed that Data Ajax endlessly calls
wb.init
- even after it's fulfilled its purpose (i.e. done AJAXing-in data). Anif
condition in wb.init prevents anything further from happening during the endless calls.It looks like this behaviour was first introduced by #6076. That PR's stated purpose was to fix an infinite loop while loading - but in practice it seems to have had the opposite effect :S.
I tested the Data Ajax demo page in WET 4.0.5 (before) and 4.0.6's (after) production files with the following results:
wb-data-ajax-*
(expected)wb-data-ajax-*
andwb-prettify
(prettify is setup on a parent element of some of the examples - so it was brought along for the ride)To Reproduce (master branch)
grunt
Expected behaviour
A bunch of init messages appear during initial page load and cease after all the data has finished AJAXing-in.
Actual behaviour
Same as expected behaviour... but then the following init messages get spammed forever:
Who shall do the work?
Anyone. I'll send in a PR soon to try fixing it. But I'm not very experienced with plugin initialization...
Additional information
Version of WET-BOEW/GCWeb you are using
4.0.43.2 (development - i.e. master branch)
Desktop/Smartphone (please complete the following information)
Additional context
The text was updated successfully, but these errors were encountered: