Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 Not found #638

Closed
felixwerner opened this issue Jun 19, 2024 · 3 comments
Closed

404 Not found #638

felixwerner opened this issue Jun 19, 2024 · 3 comments
Labels

Comments

@felixwerner
Copy link

felixwerner commented Jun 19, 2024

when i link a project and the linked folder contains a folder named public. i get a 404 - not found for the linked url.

@mischabraam
Copy link
Member

Hi @felixwerner , this can be anything. Without more information I can't trace this to anything.
Did you park your sites root directory? Is there anything in the public directory? Which driver are you trying to use? Which framework? etc.etc.

@felixwerner
Copy link
Author

felixwerner commented Jul 9, 2024

Hi mischa thanks for getting back.

it happens on all projects.

i tested it with a empty project of only a index.php and a empty public folder.
no parked sites, no framework, nothing in the public directory.

the index.php
<?php echo "hi";

starting out it works. as soon as i add the empty public/ folder i get this 404.

@mischabraam
Copy link
Member

Hi @felixwerner , this is most likely because of the https://github.com/laravel/valet/blob/master/cli/Valet/Drivers/BasicWithPublicValetDriver.php which is a default driver delivered by Laravel's Valet.

You could write your custom valet driver if you're not using any framework, see https://laravel.com/docs/11.x/valet#custom-valet-drivers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants