Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow secure websites to use own certificate #419

Closed
2 tasks done
dverkade opened this issue Oct 18, 2019 · 2 comments
Closed
2 tasks done

Feature: Allow secure websites to use own certificate #419

dverkade opened this issue Oct 18, 2019 · 2 comments
Labels
2.x Issues / features related the the 2.x branch Feature request Feature MINOR This change is minor

Comments

@dverkade
Copy link

  • I've checked the issue queue and could not find anything similar to my feature.
  • I'm on the latest version of valet-plus (valet --version): <Valet-Plus-Version>

Why implement this feature?
Magento PWA Studio does not allow self signed certificates for development. Currently when you secure a site with Valet Plus it creates a self signed certificate.

What will be required for this feature?

  • Create the ability to add a general certificate in the certificates directory. For instance a certificate for a specific domain or a wildcard certificate.
  • When a wildcard certificate is present configure nginx to use the wildcard certificate when securing a site instead of creating a self signed certificate.
@dverkade dverkade added Feature request Feature Needs review Tickets that need review labels Oct 18, 2019
@Neodork Neodork added 2.x Issues / features related the the 2.x branch MINOR This change is minor and removed Needs review Tickets that need review labels Feb 7, 2020
@Neodork
Copy link
Collaborator

Neodork commented Feb 7, 2020

This would be possible if we track certificates per link / park and simply serve that instead. The work required to do this is quite some though.

Tagged as 2.x minor ticket

@sheshagiricorra
Copy link

Do we have any updates on this?

@mischabraam mischabraam changed the title Festure: Allow secure websites to use own certificate Feature: Allow secure websites to use own certificate Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issues / features related the the 2.x branch Feature request Feature MINOR This change is minor
Projects
None yet
Development

No branches or pull requests

4 participants