Skip to content

Validate Distribution account in approve #49

Open
@balmy-gazebo

Description

@balmy-gazebo

Currently we are not validating the distribution account because this instruction in general is called assuming marketplaces properly account for royalties, however it is poor DX to allow ambiguous distribution accounts as uncaught errors will lead to loss of funds for creators if their distribution account were passed in incorrectly by a marketplace.

The hold up implementing this is that it would require passing in the group account to derive the Distribution PDA in approve. Once the Group Account is apart of the mint account we should be able to make this check. In the mean time potentially we should add a warning to the documentation.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions