Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow :NOTER_DOCUMENT: to be in file-level :PROPERTIES: drawer #143

Open
gcoladon opened this issue Apr 19, 2021 · 2 comments
Open

Allow :NOTER_DOCUMENT: to be in file-level :PROPERTIES: drawer #143

gcoladon opened this issue Apr 19, 2021 · 2 comments

Comments

@gcoladon
Copy link

According to https://orgmode.org/Changes.html#orgdd3d5c7, properties that are set prior to the first heading work as if they are outline level 0. But when I put :NOTER_DOCUMENT: into a :PROPERTIES: drawer at the top of an org file, and try to run org-noter from below the first headline I get the Root heading not found error, and when I try to run it from above the first headline, I get the error 'org-noter must be issued inside a heading'.

In theory should org-noter work with NOTER_DOCUMENT specified at the top of the file, and it's just a matter of updating the code so that it conforms to this new feature of org-mode?

@gcoladon
Copy link
Author

Could the call to org-entry-get inside org-noter--parse-root be replaced with a call to org-entry-get-with-inheritance, to take advantage of org's ability to recurse the tree looking for an inherited property?

@benthamite
Copy link

I was about to open an issue to suggest this improvement but then noticed @gcoladon had already made it. Currently I use an org-roam capture template that creates an ID property at the very beginning of the document, before any headings, and then it creates a new heading just for the purpose of attaching to it the :NOTER_DOCUMENT: property. It would be great to be able to set this additional property next to ID, and dispense with the need to have the extra heading.

c1-g added a commit to c1-g/org-noter-plus-djvu that referenced this issue Sep 13, 2021
petermao added a commit to petermao/org-noter that referenced this issue Jan 21, 2023
This was killing performance, making note navigation take seconds to complete.
The original commits, by c1g, were supposed to resolve issue weirdNox#143.
Unfortunately, the calls to `org-collect-keywords' make navigation in large PDFs
intollerably slow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants