Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support WECHATY_PUPPET_SERVICE_TOKEN #91

Open
huan opened this issue Jan 23, 2021 · 3 comments
Open

Support WECHATY_PUPPET_SERVICE_TOKEN #91

huan opened this issue Jan 23, 2021 · 3 comments

Comments

@huan
Copy link
Member

huan commented Jan 23, 2021

  1. Add WECHATY_PUPPET_SERVICE_TOKEN support for all our Polyglot Wechaty projects.
  2. Make WECHATY_PUPPET_HOSTIE_TOKEN an alias for WECHATY_PUPPET_SERVICE_TOKEN, and print a warning message to let the user know it was deprecated with it has been set.

Learn more from wechaty/wechaty#2123

@Charles-Wu-Chen
Copy link

I can have a look at this change this weekend, if no one volunteers.

@Charles-Wu-Chen
Copy link

Have had a look in the code, Java wechaty library doesn't hardcode the token variable. it accepts the token as string. It is application to set up the token variable. So no change is required from this project.

fun instance(token: String): Wechaty {

I will update java-wechaty-getting-started project to reflect the token variable change.

https://github.com/wechaty/java-wechaty-getting-started/blob/63f9fe47ff03bb2722670786cca743bb13121d97/examples/src/main/java/io/github/wechaty/DingDongBot.java#L15

@huan
Copy link
Member Author

huan commented Jan 29, 2021

Thanks for your information that Java Wechaty does not support setting token from environment variable yet!

It would be great if we can add a WECHATY_PUPPET_SERVICE_TOKEN environment variable to Java Wechaty so that the developers can be easy to switch the Wechaty Puppet Service by simple setting the env var.

And I'm drafting a Polygram Wechaty Specification this week (here), which all the Polygram Wechaty should apply because it will make developers easily to use Wechaty when they are switching languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants