Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search to Advanced style panel #4805

Open
kof opened this issue Jan 29, 2025 · 0 comments
Open

Add search to Advanced style panel #4805

kof opened this issue Jan 29, 2025 · 0 comments
Assignees
@kof
Labels
area:styles Style Panel is the CSS panel on the right complexity:medium Up to 1 week of work prio:2 Always look for prio:1 issues first before working on prio:2 type:feat Features and enhancements

Comments

@kof
Copy link
Member

kof commented Jan 29, 2025 •
edited
Loading

As a designer I need to search css variables on the current instance, especially on the root.
@kof kof added area:styles Style Panel is the CSS panel on the right type:feat Features and enhancements complexity:medium Up to 1 week of work prio:2 Always look for prio:1 issues first before working on prio:2 labels Jan 29, 2025
This was referenced Feb 9, 2025
Open
Merged
@kof kof self-assigned this Feb 12, 2025
kof added a commit that referenced this issue Feb 14, 2025
@kof
feat: Search for advanced section in style panel (#4862)
ecb23c0 
#4805

## Description

1. start searching
2. abort with esc
3. try in default as well as in advanced mode
4. try with recent changes and without

## Steps for reproduction

1. click button
5. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kof kof

Labels
area:styles Style Panel is the CSS panel on the right complexity:medium Up to 1 week of work prio:2 Always look for prio:1 issues first before working on prio:2 type:feat Features and enhancements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kof