fix clippy/fmt

Author: yngrtc

data/src/message/message_channel_open.rs

@@ -17,10 +17,11 @@ pub const CHANNEL_PRIORITY_NORMAL: u16 = 256;
 pub const CHANNEL_PRIORITY_HIGH: u16 = 512;
 pub const CHANNEL_PRIORITY_EXTRA_HIGH: u16 = 1024;
 
-#[derive(Eq, PartialEq, Copy, Clone, Debug)]
+#[derive(Default, Eq, PartialEq, Copy, Clone, Debug)]
 pub enum ChannelType {
     // `Reliable` determines the Data Channel provides a
     // reliable in-order bi-directional communication.
+    #[default]
     Reliable,
     // `ReliableUnordered` determines the Data Channel
     // provides a reliable unordered bi-directional communication.
@@ -46,12 +47,6 @@ pub enum ChannelType {
     PartialReliableTimedUnordered,
 }
 
-impl Default for ChannelType {
-    fn default() -> Self {
-        Self::Reliable
-    }
-}
-
 impl MarshalSize for ChannelType {
     fn marshal_size(&self) -> usize {
         CHANNEL_TYPE_LEN

ice/src/candidate/mod.rs

@@ -89,9 +89,10 @@ pub trait Candidate: fmt::Display {
 }
 
 /// Represents the type of candidate `CandidateType` enum.
-#[derive(Clone, Copy, Debug, PartialEq, Eq, Serialize, Deserialize)]
+#[derive(Default, Clone, Copy, Debug, PartialEq, Eq, Serialize, Deserialize)]
 pub enum CandidateType {
     #[serde(rename = "unspecified")]
+    #[default]
     Unspecified,
     #[serde(rename = "host")]
     Host,
@@ -117,12 +118,6 @@ impl fmt::Display for CandidateType {
     }
 }
 
-impl Default for CandidateType {
-    fn default() -> Self {
-        Self::Unspecified
-    }
-}
-
 impl CandidateType {
     /// Returns the preference weight of a `CandidateType`.
     ///
@@ -171,9 +166,10 @@ impl fmt::Display for CandidateRelatedAddress {
 }
 
 /// Represent the ICE candidate pair state.
-#[derive(Clone, Copy, Debug, PartialEq, Eq, Serialize, Deserialize)]
+#[derive(Default, Clone, Copy, Debug, PartialEq, Eq, Serialize, Deserialize)]
 pub enum CandidatePairState {
     #[serde(rename = "unspecified")]
+    #[default]
     Unspecified = 0,
 
     /// Means a check has not been performed for this pair.
@@ -206,12 +202,6 @@ impl From<u8> for CandidatePairState {
     }
 }
 
-impl Default for CandidatePairState {
-    fn default() -> Self {
-        Self::Unspecified
-    }
-}
-
 impl fmt::Display for CandidatePairState {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         let s = match *self {

ice/src/control/mod.rs

@@ -108,19 +108,14 @@ impl Getter for AttrControl {
 
 /// Represents ICE agent role, which can be controlling or controlled.
 /// Possible ICE agent roles.
-#[derive(PartialEq, Eq, Copy, Clone, Debug)]
+#[derive(Default, PartialEq, Eq, Copy, Clone, Debug)]
 pub enum Role {
+    #[default]
     Controlling,
     Controlled,
     Unspecified,
 }
 
-impl Default for Role {
-    fn default() -> Self {
-        Self::Controlling
-    }
-}
-
 impl From<&str> for Role {
     fn from(raw: &str) -> Self {
         match raw {

ice/src/mdns/mod.rs

@@ -12,24 +12,19 @@ use uuid::Uuid;
 use crate::error::Result;
 
 /// Represents the different Multicast modes that ICE can run.
-#[derive(PartialEq, Eq, Debug, Copy, Clone)]
+#[derive(Default, PartialEq, Eq, Debug, Copy, Clone)]
 pub enum MulticastDnsMode {
     /// Means remote mDNS candidates will be discarded, and local host candidates will use IPs.
     Disabled,
 
     /// Means remote mDNS candidates will be accepted, and local host candidates will use IPs.
+    #[default]
     QueryOnly,
 
     /// Means remote mDNS candidates will be accepted, and local host candidates will use mDNS.
     QueryAndGather,
 }
 
-impl Default for MulticastDnsMode {
-    fn default() -> Self {
-        Self::QueryOnly
-    }
-}
-
 pub(crate) fn generate_multicast_dns_name() -> String {
     // https://tools.ietf.org/id/draft-ietf-rtcweb-mdns-ice-candidates-02.html#gathering
     // The unique name MUST consist of a version 4 UUID as defined in [RFC4122], followed by “.local”.

ice/src/network_type/mod.rs

@@ -22,9 +22,10 @@ pub fn supported_network_types() -> Vec<NetworkType> {
 }
 
 /// Represents the type of network.
-#[derive(PartialEq, Debug, Copy, Clone, Eq, Hash, Serialize, Deserialize)]
+#[derive(Default, PartialEq, Debug, Copy, Clone, Eq, Hash, Serialize, Deserialize)]
 pub enum NetworkType {
     #[serde(rename = "unspecified")]
+    #[default]
     Unspecified,
 
     /// Indicates UDP over IPv4.
@@ -69,12 +70,6 @@ impl fmt::Display for NetworkType {
     }
 }
 
-impl Default for NetworkType {
-    fn default() -> Self {
-        Self::Unspecified
-    }
-}
-
 impl NetworkType {
     /// Returns true when network is UDP4 or UDP6.
     #[must_use]

ice/src/state/mod.rs

@@ -4,8 +4,9 @@ mod state_test;
 use std::fmt;
 
 /// An enum showing the state of a ICE Connection List of supported States.
-#[derive(Debug, Copy, Clone, PartialEq, Eq)]
+#[derive(Default, Debug, Copy, Clone, PartialEq, Eq)]
 pub enum ConnectionState {
+    #[default]
     Unspecified,
 
     /// ICE agent is gathering addresses.
@@ -30,12 +31,6 @@ pub enum ConnectionState {
     Closed,
 }
 
-impl Default for ConnectionState {
-    fn default() -> Self {
-        Self::Unspecified
-    }
-}
-
 impl fmt::Display for ConnectionState {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         let s = match *self {
@@ -68,8 +63,9 @@ impl From<u8> for ConnectionState {
 }
 
 /// Describes the state of the candidate gathering process.
-#[derive(PartialEq, Eq, Copy, Clone)]
+#[derive(Default, PartialEq, Eq, Copy, Clone)]
 pub enum GatheringState {
+    #[default]
     Unspecified,
 
     /// Indicates candidate gathering is not yet started.
@@ -93,12 +89,6 @@ impl From<u8> for GatheringState {
     }
 }
 
-impl Default for GatheringState {
-    fn default() -> Self {
-        Self::Unspecified
-    }
-}
-
 impl fmt::Display for GatheringState {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         let s = match *self {

ice/src/tcp_type/mod.rs

@@ -10,9 +10,10 @@ use std::fmt;
 /// * [RFC 6544 §4.5]
 ///
 /// [RFC 6544 §4.5]: https://tools.ietf.org/html/rfc6544#section-4.5
-#[derive(PartialEq, Eq, Debug, Copy, Clone)]
+#[derive(Default, PartialEq, Eq, Debug, Copy, Clone)]
 pub enum TcpType {
     /// The default value. For example UDP candidates do not need this field.
+    #[default]
     Unspecified,
     /// Active TCP candidate, which initiates TCP connections.
     Active,
@@ -45,9 +46,3 @@ impl fmt::Display for TcpType {
         write!(f, "{s}")
     }
 }
-
-impl Default for TcpType {
-    fn default() -> Self {
-        Self::Unspecified
-    }
-}

ice/src/url/mod.rs

@@ -9,7 +9,7 @@ use stun::{DEFAULT_PORT, DEFAULT_TLS_PORT};
 use crate::error::*;
 
 /// The type of server used in the ice.URL structure.
-#[derive(PartialEq, Eq, Debug, Copy, Clone)]
+#[derive(Default, PartialEq, Eq, Debug, Copy, Clone)]
 pub enum SchemeType {
     /// The URL represents a STUN server.
     Stun,
@@ -24,15 +24,10 @@ pub enum SchemeType {
     Turns,
 
     /// Default public constant to use for "enum" like struct comparisons when no value was defined.
+    #[default]
     Unknown,
 }
 
-impl Default for SchemeType {
-    fn default() -> Self {
-        Self::Unknown
-    }
-}
-
 impl From<&str> for SchemeType {
     /// Defines a procedure for creating a new `SchemeType` from a raw
     /// string naming the scheme type.
@@ -61,9 +56,10 @@ impl fmt::Display for SchemeType {
 }
 
 /// The transport protocol type that is used in the `ice::url::Url` structure.
-#[derive(PartialEq, Eq, Debug, Copy, Clone)]
+#[derive(Default, PartialEq, Eq, Debug, Copy, Clone)]
 pub enum ProtoType {
     /// The URL uses a UDP transport.
+    #[default]
     Udp,
 
     /// The URL uses a TCP transport.
@@ -72,12 +68,6 @@ pub enum ProtoType {
     Unknown,
 }
 
-impl Default for ProtoType {
-    fn default() -> Self {
-        Self::Udp
-    }
-}
-
 // defines a procedure for creating a new ProtoType from a raw
 // string naming the transport protocol type.
 impl From<&str> for ProtoType {

webrtc/src/api/media_engine/mod.rs

@@ -105,7 +105,7 @@ impl MediaEngine {
     /// register_default_codecs is not safe for concurrent use.
     pub fn register_default_codecs(&mut self) -> Result<()> {
         // Default Audio Codecs
-        for codec in vec![
+        for codec in [
             RTCRtpCodecParameters {
                 capability: RTCRtpCodecCapability {
                     mime_type: MIME_TYPE_OPUS.to_owned(),

webrtc/src/peer_connection/peer_connection_test.rs

@@ -867,8 +867,12 @@ async fn test_receiver_reuse_during_renegotiation_issue_749() -> Result<()> {
         "stream_initial".to_owned(),
     ));
 
-    pc_offer.add_track(Arc::clone(&video_track) as Arc<dyn TrackLocal + Send + Sync>).await?;
-    pc_offer.add_track(Arc::clone(&audio_track) as Arc<dyn TrackLocal + Send + Sync>).await?;
+    pc_offer
+        .add_track(Arc::clone(&video_track) as Arc<dyn TrackLocal + Send + Sync>)
+        .await?;
+    pc_offer
+        .add_track(Arc::clone(&audio_track) as Arc<dyn TrackLocal + Send + Sync>)
+        .await?;
 
     // Step 2: Perform initial negotiation
     signal_pair(&mut pc_offer, &mut pc_answer).await?;
@@ -921,7 +925,9 @@ async fn test_receiver_reuse_during_renegotiation_issue_749() -> Result<()> {
         "stream_new".to_owned(),
     ));
 
-    pc_offer.add_track(new_video_track as Arc<dyn TrackLocal + Send + Sync>).await?;
+    pc_offer
+        .add_track(new_video_track as Arc<dyn TrackLocal + Send + Sync>)
+        .await?;
 
     // Step 5: Perform renegotiation
     let reoffer = pc_offer.create_offer(None).await?;