Skip to content

Allow only one behavior selection #2541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SuaYoo opened this issue Apr 8, 2025 · 2 comments
Open

Allow only one behavior selection #2541

SuaYoo opened this issue Apr 8, 2025 · 2 comments
Assignees
Labels
front end Requires front end dev work

Comments

@SuaYoo
Copy link
Member

SuaYoo commented Apr 8, 2025

The UI and API currently allows selecting multiple built-in behaviors or custom behaviors. The crawler actually only will run autoclick, autoscroll, OR a custom behavior. The UI should reflect the exclusion options.

If there are existing workflows with both autoscroll and autoclick enabled, autoscroll should be unchecked in favor of autoclick, which is opt-in.

@SuaYoo SuaYoo added the front end Requires front end dev work label Apr 8, 2025
@SuaYoo SuaYoo self-assigned this Apr 8, 2025
@ikreymer ikreymer moved this from Triage to Todo in Webrecorder Projects Apr 8, 2025
@SuaYoo SuaYoo moved this from Todo to Implementing in Webrecorder Projects Apr 8, 2025
@tw4l
Copy link
Member

tw4l commented Apr 8, 2025

This could probably use a little whiteboarding, as there are a few complexities. Just off of the top of my head, as examples:

  • In a crawl with a scope that covers multiple pages and/or websites, we may want custom behaviors to run on a page if they match but autoclick to run if a custom behavior doesn't match
  • If someone develops a custom behavior for a site where we have a built-in site specific behavior (such as Facebook or Tiktok), I'm also not sure which would take precedence at this point

I think not all of this complexity is introduced by adding custom behaviors, but it certainly highlights the need to figure out a design solution and effectively communicate to users what they can expect.

ikreymer pushed a commit that referenced this issue Apr 8, 2025
WIP for #2541

## Changes

- Moves custom behaviors table to behind "Use Custom Behaviors"
checkbox.
- Updates autoclick selector to match checkbox reveal layout.
- Adds minimum viable user guide documentation of custom behaviors.
@SuaYoo SuaYoo moved this from Implementing to In Design in Webrecorder Projects Apr 15, 2025
@ikreymer
Copy link
Member

Yeah, the issue is that the crawler only will run autoclick, autoscroll, OR a custom behavior per page, but different pages could have different rules. Autoclick and Autoscroll can both run on the same page, but its sort of not recommended, can result in unexpected results - though perhaps can be improved. The custom behavior only runs if it matches the specific regex.

@ikreymer ikreymer moved this from In Design to Todo in Webrecorder Projects Apr 22, 2025
@SuaYoo SuaYoo removed this from the Custom Behaviors and Link Selectors milestone Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front end Requires front end dev work
Projects
Status: Todo
Development

No branches or pull requests

3 participants