Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 @turbo/gen uncorrectly reported as unused dependency #809

Open
6 tasks done
AndreaPontrandolfo opened this issue Oct 9, 2024 · 3 comments
Open
6 tasks done
Labels
bug Something isn't working

Comments

@AndreaPontrandolfo
Copy link

Prerequisites

Reproduction url

https://stackblitz.com/edit/github-vhat6u?file=package.json

Reproduction access

  • I've made sure the reproduction is publicly accessible

Description of the issue

Turbo gen is used in a script, shouldn't be reported as unused.

@AndreaPontrandolfo AndreaPontrandolfo added the bug Something isn't working label Oct 9, 2024
@webpro
Copy link
Collaborator

webpro commented Oct 9, 2024

The turbo package contains the turbo binary, while @turbo/gen does not.

Perhaps @turbo/gen should be a (peer) dependency of turbo, but it's not.

Not sure how Knip could do better here.

@webpro
Copy link
Collaborator

webpro commented Nov 12, 2024

What do you think, @AndreaPontrandolfo? Do you think Knip has a bug or could do better here?

@AndreaPontrandolfo
Copy link
Author

A lot of people, projects, companies use turbo. So i think a lot of people eventually would run into this.

CC @anthonyshew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants