Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insufficient handling of Accept header #156

Open
kreynolds opened this issue Mar 28, 2014 · 1 comment
Open

Insufficient handling of Accept header #156

kreynolds opened this issue Mar 28, 2014 · 1 comment
Labels

Comments

@kreynolds
Copy link

I've run across this in a number of projects so I'm adding it here as an FYI. Accept headers can contain a number of things including quoted tokens, spaces between quality and type.subtype, etc and while the spec seems to indicate that quality should go first after the type, it appears optional/unclear in subsequent examples. I don't have the time to actually put it together in a PR but maybe somebody else can. The bit that returns Mime::Whatever would need to be changed but the rest appears sound.

https://github.com/kreynolds/rails/blob/fix-broken-mime-parsing-and-ordering/actionpack/lib/action_dispatch/http/mime_type.rb#L140

@ghost
Copy link

ghost commented Jun 19, 2014

Relevant previous work for improving Accept handling: #130

@ghost ghost added the feature label Jun 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant