Skip to content

set-project-id fix#4970

Merged
adrians5j merged 5 commits intonextfrom
adrian/set-pro-id-fix-2026-03-03
Mar 3, 2026
Merged

set-project-id fix#4970
adrians5j merged 5 commits intonextfrom
adrian/set-pro-id-fix-2026-03-03

Conversation

@adrians5j
Copy link
Member

@adrians5j adrians5j commented Mar 3, 2026

Two bugs in the project linking flow:

  1. SetProjectIdService incorrectly matched <Project.*> elements nested inside conditional expressions when determining the JSX insertion point — now restricted to direct children of the outermost JSX fragment.

  2. LinkProjectCommand was passing only projectId to setProjectId; it now passes the fully-qualified {orgId}/{projectId} composite ID.

// Before
await projectSdk.setProjectId(selectedProject.id, { force: true });

// After
await projectSdk.setProjectId(`${selectedOrg.id}/${selectedProject.id}`, { force: true });

@adrians5j adrians5j changed the title wip:1 (vja3t) set-project-id fix Mar 3, 2026
@Pavel910 Pavel910 added this to the 6.0.0 milestone Mar 3, 2026
@adrians5j
Copy link
Member Author

@copilot update PR body

Copy link
Contributor

Copilot AI commented Mar 3, 2026

@adrians5j I've opened a new pull request, #4971, to work on those changes. Once the pull request is ready, I'll request review from you.

@adrians5j adrians5j merged commit 5facada into next Mar 3, 2026
16 checks passed
@adrians5j adrians5j deleted the adrian/set-pro-id-fix-2026-03-03 branch March 5, 2026 08:21
Copilot AI pushed a commit to loomery/aibenchmarking-webiny-js-backend-ai-arena that referenced this pull request Mar 6, 2026
Copilot AI pushed a commit to loomery/aibenchmarking-webiny-js-backend-ai-arena that referenced this pull request Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants