-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebDriver executor ends each testdriver
action with the testharness.js
window selected
#45137
Labels
Comments
jonathan-j-lee
added
infra
wptrunner
The automated test runner, commonly called through ./wpt run
testdriver.js
labels
Mar 15, 2024
jonathan-j-lee
added a commit
that referenced
this issue
Mar 15, 2024
jonathan-j-lee
added a commit
that referenced
this issue
Mar 15, 2024
* wpt: Fix test_driver's minimize/restore functions. By default the test_driver API calls should be routed to the window corresponding to the driver. However the minimize/restore calls use the top level window. Fix this by passing the frame token to look up the correct WebContents corresponding to the blink Window. [email protected] Bug: 1522213 Change-Id: I99ed32cd4d9020d9832c63344fee004a40461148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310776 Commit-Queue: Khushal Sagar <[email protected]> Reviewed-by: danakj <[email protected]> Auto-Submit: Khushal Sagar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1263515} * Disable broken test for now with link to #45137 --------- Co-authored-by: Khushal Sagar <[email protected]> Co-authored-by: Jonathan Lee <[email protected]>
Yes, solving this properly probably requires WebDriver-BiDi support in testdriver, so we can message navigables without actually focusing them. |
BruceDai
pushed a commit
to BruceDai/wpt
that referenced
this issue
Mar 25, 2024
…s#44688) * wpt: Fix test_driver's minimize/restore functions. By default the test_driver API calls should be routed to the window corresponding to the driver. However the minimize/restore calls use the top level window. Fix this by passing the frame token to look up the correct WebContents corresponding to the blink Window. [email protected] Bug: 1522213 Change-Id: I99ed32cd4d9020d9832c63344fee004a40461148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310776 Commit-Queue: Khushal Sagar <[email protected]> Reviewed-by: danakj <[email protected]> Auto-Submit: Khushal Sagar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1263515} * Disable broken test for now with link to web-platform-tests#45137 --------- Co-authored-by: Khushal Sagar <[email protected]> Co-authored-by: Jonathan Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
See #44688 for full background.
The WebDriver implementation of
testharness.js
must switch to thetestharness.js
browsing context to runtestharness_webdriver_resume.js
. In a tabbed browser with popups in the same OS window as thetestharness.js
context, this will cause the popups to behidden
betweentest_driver.*
calls, which may make some popup visibility interactions untestable.CC @khushalsagar @jgraham
The text was updated successfully, but these errors were encountered: