Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: ignore watching files in node_modules #8645

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

chenjiahan
Copy link
Member

Summary

Update the default watchOptions configuration to improve performance by ignoring node_modules.

This will not affect symlinked resources in monorepo, as symlinked resources are resolved to their real path by default.

See web-infra-dev/rsbuild#4058 for more details.

Resolve #8511

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@chenjiahan chenjiahan marked this pull request as draft December 9, 2024 08:58
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Dec 9, 2024
@chenjiahan chenjiahan added this to the 1.2.0 milestone Dec 9, 2024
@github-actions github-actions bot added the release: performance release: performance related release(mr only) label Dec 9, 2024
Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 7b2a640
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/675839604d97910008faaf7c

@chenjiahan
Copy link
Member Author

!bench

@rspack-bot
Copy link

rspack-bot commented Dec 9, 2024

📝 Benchmark detail: Open

Name Base (2024-12-09 8646ecf) Current Change
10000_big_production-mode_disable-minimize + exec 37.1 s ± 157 ms 37 s ± 90 ms -0.51 %
10000_development-mode + exec 1.79 s ± 24 ms 1.77 s ± 30 ms -0.77 %
10000_development-mode_hmr + exec 648 ms ± 16 ms 652 ms ± 15 ms +0.63 %
10000_production-mode + exec 2.34 s ± 25 ms 2.34 s ± 27 ms +0.24 %
arco-pro_development-mode + exec 1.77 s ± 83 ms 1.75 s ± 73 ms -1.28 %
arco-pro_development-mode_hmr + exec 424 ms ± 1.3 ms 379 ms ± 2 ms -10.57 %
arco-pro_production-mode + exec 3.15 s ± 86 ms 3.1 s ± 53 ms -1.65 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.14 s ± 78 ms 3.13 s ± 80 ms -0.21 %
threejs_development-mode_10x + exec 1.62 s ± 29 ms 1.63 s ± 20 ms +0.54 %
threejs_development-mode_10x_hmr + exec 781 ms ± 11 ms 790 ms ± 4.3 ms +1.13 %
threejs_production-mode_10x + exec 4.86 s ± 38 ms 4.88 s ± 35 ms +0.33 %
10000_big_production-mode_disable-minimize + rss memory 9774 MiB ± 22.1 MiB 9823 MiB ± 36.2 MiB +0.50 %
10000_development-mode + rss memory 815 MiB ± 36 MiB 816 MiB ± 48.3 MiB +0.10 %
10000_development-mode_hmr + rss memory 2094 MiB ± 254 MiB 2007 MiB ± 251 MiB -4.16 %
10000_production-mode + rss memory 696 MiB ± 26.9 MiB 702 MiB ± 28.3 MiB +0.89 %
arco-pro_development-mode + rss memory 718 MiB ± 28.2 MiB 706 MiB ± 25.2 MiB -1.65 %
arco-pro_development-mode_hmr + rss memory 914 MiB ± 105 MiB 779 MiB ± 109 MiB -14.79 %
arco-pro_production-mode + rss memory 785 MiB ± 48.6 MiB 811 MiB ± 52.5 MiB +3.43 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 814 MiB ± 50.1 MiB 823 MiB ± 36.6 MiB +1.06 %
threejs_development-mode_10x + rss memory 789 MiB ± 45.3 MiB 786 MiB ± 50.8 MiB -0.32 %
threejs_development-mode_10x_hmr + rss memory 1728 MiB ± 255 MiB 1781 MiB ± 333 MiB +3.11 %
threejs_production-mode_10x + rss memory 1146 MiB ± 82.1 MiB 1134 MiB ± 44.2 MiB -1.09 %

@web-infra-dev web-infra-dev deleted a comment from rspack-bot Dec 9, 2024
@chenjiahan chenjiahan marked this pull request as ready for review December 10, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Long shutdown time of serve mode
2 participants