refactor: unify the logic of span_to_location into trait SourcePosition
#8640
+90
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
shulaoda
commented
Dec 7, 2024
Comment on lines
+184
to
+185
| impl SourceLocation for &str { | ||
| fn look_up_range_pos(&self, start: u32, end: u32) -> Option<(SourcePosition, SourcePosition)> { |
There was a problem hiding this comment.
I can't implement that method for dyn rspack_sources::Source. Perhaps we should implement a lookup_char_pos method on the Source trait, similar to the one in swc_core::common::SourceMap.
shulaoda
force-pushed
the
refactor/remove-unnecessary-location-transform
branch
from
11f668d to
7a1ea2e
Compare
shulaoda
changed the title
span_to_locationspan_to_location into trait SourcePosition
shulaoda
force-pushed
the
refactor/remove-unnecessary-location-transform
branch
from
7a1ea2e to
04f82d8
Compare
shulaoda
force-pushed
the
refactor/remove-unnecessary-location-transform
branch
from
04f82d8 to
9ca53fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have unified this logic into
dependency_location.rs.rspack/crates/rspack_plugin_javascript/src/parser_and_generator/mod.rs
Lines 379 to 380 in 8646ecf
Checklist