Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: allocator !macos !linux !windows #8290

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

h-a-n-a
Copy link
Collaborator

@h-a-n-a h-a-n-a commented Oct 31, 2024

Summary

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@h-a-n-a
Copy link
Collaborator Author

h-a-n-a commented Oct 31, 2024

!bench

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Oct 31, 2024
Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit f124434
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6745ba6239454a00084b06e3

@rspack-bot
Copy link

rspack-bot commented Oct 31, 2024

📝 Benchmark detail: Open

Name Base (2024-10-31 02f0c85) Current Change
10000_big_production-mode + exec 49.3 s ± 1.56 s 56.9 s ± 1.48 s +15.27 %
10000_development-mode + exec 2.12 s ± 33 ms 2.67 s ± 51 ms +25.82 %
10000_development-mode_hmr + exec 638 ms ± 4.3 ms 702 ms ± 12 ms +10.09 %
10000_production-mode + exec 2.69 s ± 41 ms 3.26 s ± 37 ms +21.31 %
arco-pro_development-mode + exec 1.79 s ± 73 ms 1.9 s ± 99 ms +6.38 %
arco-pro_development-mode_hmr + exec 428 ms ± 1.1 ms 441 ms ± 0.95 ms +2.92 %
arco-pro_production-mode + exec 3.21 s ± 130 ms 3.7 s ± 232 ms +15.07 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.25 s ± 68 ms 3.67 s ± 67 ms +12.67 %
threejs_development-mode_10x + exec 1.62 s ± 20 ms 1.9 s ± 19 ms +16.69 %
threejs_development-mode_10x_hmr + exec 770 ms ± 13 ms 841 ms ± 17 ms +9.33 %
threejs_production-mode_10x + exec 5.01 s ± 27 ms 6.32 s ± 28 ms +26.08 %

Threshold exceeded: ["10000_big_production-mode + exec","10000_development-mode + exec","10000_development-mode_hmr + exec","10000_production-mode + exec","arco-pro_development-mode + exec","arco-pro_production-mode + exec","arco-pro_production-mode_generate-package-json-webpack-plugin + exec","threejs_development-mode_10x + exec","threejs_development-mode_10x_hmr + exec","threejs_production-mode_10x + exec"]

@h-a-n-a h-a-n-a changed the title feat: use default allocator by default feat: use default allocator by default !macos !linux !windows Nov 1, 2024
@h-a-n-a

This comment was marked as outdated.

@rspack-bot

This comment was marked as outdated.

@h-a-n-a h-a-n-a force-pushed the default-allocator branch 5 times, most recently from 9a51304 to cc9260e Compare November 5, 2024 10:19
@h-a-n-a

This comment was marked as outdated.

@rspack-bot

This comment was marked as outdated.

@h-a-n-a
Copy link
Collaborator Author

h-a-n-a commented Nov 5, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented Nov 5, 2024

📝 Benchmark detail: Open

Name Base (2024-11-05 9c56263) Current Change
10000_big_production-mode + exec 43.9 s ± 638 ms 43.7 s ± 633 ms -0.49 %
10000_development-mode + exec 1.83 s ± 22 ms 1.83 s ± 28 ms +0.07 %
10000_development-mode_hmr + exec 644 ms ± 4.4 ms 644 ms ± 6 ms +0.03 %
10000_production-mode + exec 2.41 s ± 19 ms 2.43 s ± 46 ms +1.00 %
arco-pro_development-mode + exec 1.75 s ± 55 ms 1.78 s ± 78 ms +1.94 %
arco-pro_development-mode_hmr + exec 430 ms ± 1.5 ms 431 ms ± 0.48 ms +0.10 %
arco-pro_production-mode + exec 3.21 s ± 75 ms 3.21 s ± 89 ms -0.06 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.24 s ± 57 ms 3.27 s ± 85 ms +1.13 %
threejs_development-mode_10x + exec 1.58 s ± 7.7 ms 1.58 s ± 15 ms +0.27 %
threejs_development-mode_10x_hmr + exec 771 ms ± 19 ms 777 ms ± 9.8 ms +0.76 %
threejs_production-mode_10x + exec 4.95 s ± 27 ms 4.96 s ± 27 ms +0.24 %

@rspack-bot
Copy link

rspack-bot commented Nov 5, 2024

📝 Benchmark detail: Open

Name Base (2024-11-05 9c56263) Current Change
10000_big_production-mode + exec 43.9 s ± 638 ms 43.6 s ± 986 ms -0.71 %
10000_development-mode + exec 1.83 s ± 22 ms 1.82 s ± 29 ms -0.28 %
10000_development-mode_hmr + exec 644 ms ± 4.4 ms 643 ms ± 5.5 ms -0.11 %
10000_production-mode + exec 2.41 s ± 19 ms 2.41 s ± 23 ms +0.15 %
arco-pro_development-mode + exec 1.75 s ± 55 ms 1.77 s ± 87 ms +1.09 %
arco-pro_development-mode_hmr + exec 430 ms ± 1.5 ms 430 ms ± 0.74 ms -0.03 %
arco-pro_production-mode + exec 3.21 s ± 75 ms 3.19 s ± 65 ms -0.56 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.24 s ± 57 ms 3.26 s ± 86 ms +0.84 %
threejs_development-mode_10x + exec 1.58 s ± 7.7 ms 1.59 s ± 17 ms +0.72 %
threejs_development-mode_10x_hmr + exec 771 ms ± 19 ms 773 ms ± 11 ms +0.21 %
threejs_production-mode_10x + exec 4.95 s ± 27 ms 4.98 s ± 26 ms +0.62 %

@h-a-n-a h-a-n-a force-pushed the default-allocator branch 2 times, most recently from f941209 to cdaa511 Compare November 19, 2024 06:40
@h-a-n-a h-a-n-a changed the title feat: use default allocator by default !macos !linux !windows refactor: allocator !macos !linux !windows Nov 19, 2024
@h-a-n-a
Copy link
Collaborator Author

h-a-n-a commented Nov 19, 2024

!bench

@github-actions github-actions bot removed the release: feature release: feature related release(mr only) label Nov 19, 2024
@rspack-bot
Copy link

rspack-bot commented Nov 19, 2024

📝 Benchmark detail: Open

Name Base (2024-11-19 bf83b48) Current Change
10000_big_production-mode_disable-minimize + exec 39.8 s ± 1.09 s 39.7 s ± 811 ms -0.19 %
10000_development-mode + exec 1.84 s ± 44 ms 1.82 s ± 25 ms -1.01 %
10000_development-mode_hmr + exec 644 ms ± 10 ms 638 ms ± 8.7 ms -0.97 %
10000_production-mode + exec 2.44 s ± 24 ms 2.39 s ± 44 ms -2.07 %
arco-pro_development-mode + exec 1.8 s ± 69 ms 1.76 s ± 68 ms -1.81 %
arco-pro_development-mode_hmr + exec 430 ms ± 1.5 ms 429 ms ± 2.1 ms -0.21 %
arco-pro_production-mode + exec 3.17 s ± 62 ms 3.15 s ± 72 ms -0.66 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.2 s ± 43 ms 3.17 s ± 69 ms -0.94 %
threejs_development-mode_10x + exec 1.57 s ± 16 ms 1.57 s ± 17 ms -0.06 %
threejs_development-mode_10x_hmr + exec 778 ms ± 6.1 ms 779 ms ± 4.8 ms +0.05 %
threejs_production-mode_10x + exec 4.97 s ± 37 ms 4.91 s ± 30 ms -1.05 %

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants