Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: simplify statements for readability #8228

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

style: simplify statements for readability #8228

wants to merge 2 commits into from

Conversation

hamirmahal
Copy link

Summary

Fixes #8227

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify Netlify
Copy link

netlify bot commented Oct 26, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit e8a5af6
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/671d2a17b1f4ac00084f0cd2

hamirmahal
hamirmahal commented Oct 26, 2024
View reviewed changes
Copy link
Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request shouldn't cause any user-facing changes.

The goal here is to improve the codebase's maintainability and developer productivity.

@chenjiahan chenjiahan requested a review from h-a-n-a October 28, 2024 02:19
@h-a-n-a
Copy link
Collaborator

h-a-n-a commented Oct 28, 2024

Style changes would be better with clippy rule changes. Would you please see if there's any rule can help us avoid regressions?

@hamirmahal
Copy link
Author

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some panic and other statements can be simplified
3 participants
@hamirmahal @CLAassistant @h-a-n-a