fix: test case

Author: SyMind

crates/node_binding/src/error.rs

@@ -317,7 +317,6 @@ impl RspackError {
   pub fn into_diagnostic(mut self, severity: RspackSeverity) -> Diagnostic {
     self.severity = Some(severity.into());
 
-    let message = self.message.clone();
     let details = self.details.clone();
     let file = self.file.clone();
     let loc = self.loc.as_ref().map(Into::into);
@@ -337,7 +336,6 @@ impl RspackError {
     };
 
     diagnostic
-      .with_message(message)
       .with_details(details)
       .with_file(file.map(Into::into))
       .with_loc(loc)

crates/rspack_error/src/diagnostic.rs

@@ -74,7 +74,6 @@ pub struct Diagnostic {
 
   // The following fields are only used to restore Diagnostic for Rspack.
   // If the current Diagnostic originates from Rust, these fields will be None.
-  message: Option<String>,
   details: Option<String>,
   module_identifier: Option<Identifier>,
   loc: Option<DependencyLocation>,
@@ -94,7 +93,6 @@ impl From<miette::Error> for Diagnostic {
   fn from(value: miette::Error) -> Self {
     Self {
       inner: Arc::new(value),
-      message: None,
       details: None,
       module_identifier: None,
       loc: None,
@@ -123,7 +121,6 @@ impl Diagnostic {
           .with_severity(miette::Severity::Warning),
       )
       .into(),
-      message: None,
       details: None,
       module_identifier: None,
       loc: None,
@@ -142,7 +139,6 @@ impl Diagnostic {
           .with_severity(miette::Severity::Error),
       )
       .into(),
-      message: None,
       details: None,
       module_identifier: None,
       loc: None,
@@ -170,27 +166,7 @@ impl Diagnostic {
   }
 
   pub fn message(&self) -> String {
-    match &self.message {
-      Some(message) => message.clone(),
-      None => {
-        let mut name = "Error".to_string();
-        if let Some(code) = self.inner.code() {
-          name = code.to_string();
-        }
-
-        let mut message = self.inner.to_string();
-        let prefix = format!("{name}: ");
-        if message.starts_with(&prefix) {
-          message = message[prefix.len()..].to_string();
-        }
-        message
-      }
-    }
-  }
-
-  pub fn with_message(mut self, message: String) -> Self {
-    self.message = Some(message);
-    self
+    self.inner.to_string()
   }
 
   pub fn severity(&self) -> Severity {

packages/rspack-test-tools/tests/configCases/errors/hide-stack/errors.js

@@ -1,6 +1,4 @@
 module.exports = [
   [/emit message hide/, { details: /emit stack hide/ }],
-  [/emit stack/],
-  [/throw message hide/, { details: /throw stack hide/ }],
-  [/throw stack/],
+  [/emit stack/]
 ]

packages/rspack-test-tools/tests/configCases/errors/hide-stack/index.js

@@ -1,10 +1,3 @@
-it("should hide stack in details when throw", function () {
-	expect(function f() {
-		require("./loader-throw!");
-		require("./loader-throw-hide!");
-	}).toThrowError();
-});
-
 it("should hide stack in details when emit", function () {
 	expect(function f() {
 		require("./loader-emit!");

packages/rspack-test-tools/tests/configCases/errors/hide-stack/loader-throw-hide.js

@@ -9,7 +9,6 @@ module.exports = {
 					for (let error of errors) {
 						if (error.message.includes("hide")) {
 							expect(typeof error.details).toBe("string");
-							expect(error.message.includes("stack")).toBeFalsy;
 						} else {
 							expect(typeof error.details).toBe("undefined");
 						}