Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PHP 8.4 deprecations #683

Closed
spackmat opened this issue Jan 25, 2025 · 3 comments
Closed

Remove PHP 8.4 deprecations #683

spackmat opened this issue Jan 25, 2025 · 3 comments

Comments

@spackmat
Copy link

Description

Hi,

the webauthn-lib and all seem to work well with PHP 8.4, but I get a lot of deprecation warnings: Implicitly marking parameter as nullable is deprecated, the explicit nullable type must be used instead

Is someone already working on it? There is a Rector rule for that, so it should be easy for everyone having the dev stuff already on hand: https://getrector.com/rule-detail/explicit-nullable-param-type-rector If not, I could step in next week or so and submit a PR for those changes.

Greets

Example

No response

@Spomky
Copy link
Contributor

Spomky commented Feb 2, 2025

Hi @spackmat,

These warnings should be fixed by #661 and #662 on both 4.9 and 5.1 branches.
Can you be more precise on the versions you use and the variables that are not up to date?

Many thanks.
Regards.

@spackmat
Copy link
Author

spackmat commented Feb 2, 2025

Oh, nevermind, I had a stupid version constraint in my composer.json and was still on the 5.0 branch.

@spackmat spackmat closed this as completed Feb 2, 2025
@Spomky
Copy link
Contributor

Spomky commented Feb 2, 2025

😅 not so stupid; there is an issue with the doctrine storage with non pgsql databases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants