-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Android's FIDO2 origin #393
Comments
Hi,
Good question. At first sight I would say yes. Let me dig deeper in the documentation before. Regards. |
Thanks for the quick answer! I started implementing it in a fork. I'd have to edit out some elements of options and authenticator response before posting it here. Not sure it would be helpful to you then? |
What is the status of this issue? Did you have a working fork @giann ? Would a PR be appreciated? If so, what solution is desired? I was thinking of being able to provide a list of whitelisted origins maybe? Or integration/interpretation of the .well-known/assetlinks.json? Here is a sample clientData json array from an android attestation request {
"type": "webauthn.create",
"challenge": "QtZ8KlBHsey4FuBsz_Pr4fmA_hn5A3lEqFWOpoo1TXk",
"origin": "android:apk-key-hash:NztP-sfNqy2_XIe4erm4qR-w4eRJ2Dl6JduFbPCYHik",
"androidPackageName": "com.example"
} The key hash is the base64url unpadded encoding of the hex2binary decoded fingerprint listed in .well-knowns/assetlinks.json. Edit: Just forked the 4.8 branch, and i saw you guys have already made changes to the origin check, and it looks possible to hook into and whitelist origins on this version. So i think 4.8/5.0 will resolve this issue. |
Indeed. I am not sure to implement this feature and I took the opportunity of 4.8 to extract input verification to dedicated services. |
Hi I am facing the same issue on a project.
Is it already possible to validate |
The plan is to rely on an interface to validate the origins. |
@Spomky Hello, any updates here? |
Description
In Android's FIDO2 implementation, the
clientDataJSON
'sorigin
is not the rpId but a hash of the apk signature key like so:The link with the relying party is done by checking that the key's fingerprint is present at
https://my-relying-party.com/.well-known/assetlinks.json
.Would it be possible for webauthn-framework to support this?
The text was updated successfully, but these errors were encountered: