Add sprintf utility usage across multiple classes (#669)

Introduced `sprintf` function in various classes to improve code consistency and formatting operations. Additionally, minor adjustments were made to PHP versions in workflows and the removal of unnecessary PHPUnit configurations.

Author: Spomky

.github/workflows/integrate.yml

@@ -59,9 +59,7 @@ jobs:
           - "8.1"
           - "8.2"
           - "8.3"
-        dependencies:
-          - "lowest"
-          - "highest"
+          - "8.4"
     runs-on: ${{ matrix.operating-system }}
     steps:
       - name: "Set up PHP"
@@ -98,7 +96,7 @@ jobs:
         operating-system:
           - "ubuntu-latest"
         php-version:
-          - "8.2"
+          - "8.3"
     runs-on: ${{ matrix.operating-system }}
     steps:
       - name: "Set up PHP"

composer.json

@@ -120,7 +120,6 @@
         "symfony/filesystem": "^6.4|^7.0",
         "symfony/finder": "^6.4|^7.0",
         "symfony/monolog-bundle": "^3.8",
-        "symfony/phpunit-bridge": "^6.4|^7.0",
         "symfony/var-dumper": "^6.4|^7.0",
         "symfony/yaml": "^6.4|^7.0",
         "symplify/easy-coding-standard": "^12.0"

phpstan-baseline.neon

@@ -2706,6 +2706,11 @@ parameters:
 			count: 1
 			path: src/webauthn/src/MetadataService/Service/DistantResourceMetadataService.php
 
+		-
+			message: "#^Property Webauthn\\\\MetadataService\\\\Service\\\\DistantResourceMetadataService\\:\\:\\$serializer \\(Symfony\\\\Component\\\\Serializer\\\\SerializerInterface\\|null\\) is never assigned null so it can be removed from the property type\\.$#"
+			count: 1
+			path: src/webauthn/src/MetadataService/Service/DistantResourceMetadataService.php
+
 		-
 			message: "#^Argument of an invalid type mixed supplied for foreach, only iterables are supported\\.$#"
 			count: 1
@@ -2759,6 +2764,11 @@ parameters:
 			count: 1
 			path: src/webauthn/src/MetadataService/Service/FidoAllianceCompliantMetadataService.php
 
+		-
+			message: "#^Property Webauthn\\\\MetadataService\\\\Service\\\\FidoAllianceCompliantMetadataService\\:\\:\\$serializer \\(Symfony\\\\Component\\\\Serializer\\\\SerializerInterface\\|null\\) is never assigned null so it can be removed from the property type\\.$#"
+			count: 1
+			path: src/webauthn/src/MetadataService/Service/FidoAllianceCompliantMetadataService.php
+
 		-
 			message: """
 				#^Call to deprecated method createFromString\\(\\) of class Webauthn\\\\MetadataService\\\\Statement\\\\MetadataStatement\\:
@@ -2772,6 +2782,11 @@ parameters:
 			count: 1
 			path: src/webauthn/src/MetadataService/Service/FolderResourceMetadataService.php
 
+		-
+			message: "#^Property Webauthn\\\\MetadataService\\\\Service\\\\FolderResourceMetadataService\\:\\:\\$serializer \\(Symfony\\\\Component\\\\Serializer\\\\SerializerInterface\\|null\\) is never assigned null so it can be removed from the property type\\.$#"
+			count: 1
+			path: src/webauthn/src/MetadataService/Service/FolderResourceMetadataService.php
+
 		-
 			message: """
 				#^Call to deprecated method createFromString\\(\\) of class Webauthn\\\\MetadataService\\\\Statement\\\\MetadataStatement\\:
@@ -2780,6 +2795,11 @@ parameters:
 			count: 1
 			path: src/webauthn/src/MetadataService/Service/JsonMetadataService.php
 
+		-
+			message: "#^Property Webauthn\\\\MetadataService\\\\Service\\\\JsonMetadataService\\:\\:\\$serializer \\(Symfony\\\\Component\\\\Serializer\\\\SerializerInterface\\|null\\) is never assigned null so it can be removed from the property type\\.$#"
+			count: 1
+			path: src/webauthn/src/MetadataService/Service/JsonMetadataService.php
+
 		-
 			message: """
 				#^Call to deprecated method createFromString\\(\\) of class Webauthn\\\\MetadataService\\\\Statement\\\\MetadataStatement\\:
@@ -2798,6 +2818,11 @@ parameters:
 			count: 1
 			path: src/webauthn/src/MetadataService/Service/LocalResourceMetadataService.php
 
+		-
+			message: "#^Property Webauthn\\\\MetadataService\\\\Service\\\\LocalResourceMetadataService\\:\\:\\$serializer \\(Symfony\\\\Component\\\\Serializer\\\\SerializerInterface\\|null\\) is never assigned null so it can be removed from the property type\\.$#"
+			count: 1
+			path: src/webauthn/src/MetadataService/Service/LocalResourceMetadataService.php
+
 		-
 			message: "#^Parameter \\#1 \\$data of static method Webauthn\\\\MetadataService\\\\Service\\\\MetadataBLOBPayloadEntry\\:\\:createFromArray\\(\\) expects array\\<string, mixed\\>, mixed given\\.$#"
 			count: 1

phpunit.xml.dist

@@ -18,9 +18,6 @@
         <ini name="error_reporting" value="-1"/>
         <server name="APP_ENV" value="test" force="true"/>
         <server name="SHELL_VERBOSITY" value="-1"/>
-        <server name="SYMFONY_PHPUNIT_REMOVE" value=""/>
-        <server name="SYMFONY_PHPUNIT_VERSION" value="10.1"/>
-        <env name="SYMFONY_DEPRECATIONS_HELPER" value="max[self]=0"/>
         <env name="APP_DEBUG" value="true"/>
         <server name="KERNEL_CLASS" value="Webauthn\Tests\Bundle\Functional\AppKernel"/>
         <ini name="memory_limit" value="-1"/>

src/symfony/src/Controller/AttestationResponseController.php

@@ -25,6 +25,7 @@
 use Webauthn\PublicKeyCredentialLoader;
 use Webauthn\PublicKeyCredentialSourceRepository;
 use Webauthn\PublicKeyCredentialUserEntity;
+use function sprintf;
 
 final class AttestationResponseController
 {

src/symfony/src/CredentialOptionsBuilder/ProfileBasedCreationOptionsBuilder.php

@@ -22,6 +22,7 @@
 use Webauthn\PublicKeyCredentialUserEntity;
 use function count;
 use function is_array;
+use function sprintf;
 use const FILTER_VALIDATE_BOOLEAN;
 
 final class ProfileBasedCreationOptionsBuilder implements PublicKeyCredentialCreationOptionsBuilder

src/symfony/src/CredentialOptionsBuilder/ProfileBasedRequestOptionsBuilder.php

@@ -23,6 +23,7 @@
 use Webauthn\PublicKeyCredentialUserEntity;
 use function count;
 use function is_array;
+use function sprintf;
 
 final class ProfileBasedRequestOptionsBuilder implements PublicKeyCredentialRequestOptionsBuilder
 {

src/symfony/src/DependencyInjection/Compiler/DynamicRouteCompilerPass.php

@@ -9,6 +9,7 @@
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Webauthn\Bundle\Routing\Loader;
 use function array_key_exists;
+use function sprintf;
 
 final class DynamicRouteCompilerPass implements CompilerPassInterface
 {

src/symfony/src/DependencyInjection/Factory/Security/WebauthnFactory.php

@@ -39,6 +39,7 @@
 use Webauthn\FakeCredentialGenerator;
 use function array_key_exists;
 use function assert;
+use function sprintf;
 
 final class WebauthnFactory implements FirewallListenerFactoryInterface, AuthenticatorFactoryInterface
 {

src/symfony/src/DependencyInjection/WebauthnExtension.php

@@ -57,6 +57,7 @@
 use function array_key_exists;
 use function count;
 use function is_array;
+use function sprintf;
 
 final class WebauthnExtension extends Extension implements PrependExtensionInterface
 {