Skip to content

Empty links in the footer on the https://opensaas.sh website #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
florim-agimi opened this issue Mar 3, 2025 · 3 comments
Open

Empty links in the footer on the https://opensaas.sh website #392

florim-agimi opened this issue Mar 3, 2025 · 3 comments

Comments

@florim-agimi
Copy link

There are 2 empty links in the footer on the https://opensaas.sh website ("Privacy" and "Terms of Service")

<div>
   <h3 class="text-sm font-semibold leading-6 text-gray-900 dark:text-white">Company</h3>
   <ul role="list" class="mt-6 space-y-4">
      <li><a href="https://wasp-lang.dev" class="text-sm leading-6 text-gray-600 hover:text-gray-900 dark:text-white">About</a></li>
      <li><a href="#" class="text-sm leading-6 text-gray-600 hover:text-gray-900 dark:text-white">Privacy</a></li>
      <li><a href="#" class="text-sm leading-6 text-gray-600 hover:text-gray-900 dark:text-white">Terms of Service</a></li>
   </ul>
</div>
@Martinsos
Copy link
Member

Hm true! @vincanger is that because we are leaving them to the user of the template to implement? In theory we could put something of our own specifically for opensaas.sh although I wonder if that is needed or not, I don't have much experience with these and the legal side of it.

@vincanger
Copy link
Collaborator

I left them blank as I didn't see a need for them. The MIT license is in the github repo so maybe we could link to that @Martinsos and remove privacy as we're using Plausible and don't collect any cookies?

@Martinsos
Copy link
Member

@vincanger sounds good to me! Hm, let's think about it this way actually: we want these to be there for people, but also to have sane defaults.
One option is to remove empy links and they can always add them. Yeah, why not, that is the safe optin.
Another optino is to have them point to be blank, but then we will want to point out in docs they will probably want to fill those in.
I am ok with removing them I tihnk.
The only option that could be problematic is if we make them point to some mock stuff, or even Wasp stuff, and then they forget to update them, and they have wrong stuff there wrong privacy and similar, or even wrong license, that wouldn't be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants