We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently our thread termination tracking logic is quite scuffed.
There is a global watchable handle that is supposed to hold thread status.
But the status is actually also used to figure out if a thread should terminate in __asyncify() calls.
__asyncify()
Calling WasiThread::terminate() currently succeeds immediately, because it sets said status.
WasiThread::terminate()
We need to separate things out into a "should shut down" status and a "has shut down" status.
The text was updated successfully, but these errors were encountered:
RUN-43 WASIX: Fix thread termination logic
Sorry, something went wrong.
theduke
Successfully merging a pull request may close this issue.
Currently our thread termination tracking logic is quite scuffed.
There is a global watchable handle that is supposed to hold thread status.
But the status is actually also used to figure out if a thread should terminate in
__asyncify()
calls.Calling
WasiThread::terminate()
currently succeeds immediately, because it sets said status.We need to separate things out into a "should shut down" status and a "has shut down" status.
The text was updated successfully, but these errors were encountered: