Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site-wide alert banner animation causes layout shift #401

Open
laymonage opened this issue Aug 25, 2023 · 2 comments
Open

Site-wide alert banner animation causes layout shift #401

laymonage opened this issue Aug 25, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@laymonage
Copy link
Member

The animation for the site-wide alert banner causes layout shift on initial load. This isn't a big issue when browsing the website, but it becomes jarring when you're using the preview panel while editing a page:

Screen.Recording.2023-08-25.at.11.42.32.mov
@laymonage laymonage added the bug Something isn't working label Aug 25, 2023
@laymonage
Copy link
Member Author

Looked into this but I couldn't find a good way to fix it, as the banner is loaded via AJAX.

Tried adding a scrollBy which seems to reduce the issue on the website, but actually causes issues on the preview panel.

@zerolab
Copy link
Collaborator

zerolab commented Aug 25, 2023

one way around it is to disable it for previews...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zerolab @laymonage