NameError: Slugify not imported in model.py in utils app

[OluwagbeminiyiA]

Issue summary

While looking at the code, I noticed slugify wasn't imported and after trying to run the code, it returned a NameError in utils/models.py.

Traceback

File "models.py", line 157, in slugify
title = slugify(title, allow_unicode=True)
^^^^^^^
NameError: name 'slugify' is not defined. Did you mean: 'self.slugify'

Steps to reproduce

1. run python manage.py shell
2. from [your_app.utils].models import ArticleTopic
3. ArticleTopic(title="test").save()

Additional information

No response

Can be reproduced

Yes, on a fresh Wagtail project

Technical details

Working on this

I can confirm this reproducible on a fresh wagtail news template project. Running the ArticleTopic(title="test").save produces a NameError and I would like to fix this by adding the missing import. I'd submit a PR shortly.

[OluwagbeminiyiA]

I'd like to fix this by submitting a PR shortly.

[JiwaniZakir]

Investigating this now, should have a patch shortly.

[vanshaj2023]

Thanks everyone for the quick fixes!

I read the issue and fixes needed to close it and I noticed there are currently three open PRs fixing this exact same issue: #95, #96, and #97. Since the maintainers will likely only merge one of them, I'd suggest adding a regression test to your PR to improve its chances of getting accepted.

Without a test, the same import could easily be accidentally removed again in the future. Something like this would be perfect:

def test_slug_is_generated_on_save(self):
    # ensure slugify import works at runtime
    topic = ArticleTopic(title="test")
    topic.save()
    self.assertEqual(topic.slug, "test")

I think whichever PR adds a test like this will probably be the one that gets merged.