Mobile navigation links broken — href="" regression from #14

[vanshaj2023]

Issue summary

Description

Issue #14 (Navigation links not working on mobile) was closed as completed in Oct 2024, but the bug has regressed and is present in the current main branch.

In templates/navigation/header.html line 123, the mobile menu links have an empty href="":

<a href="">
    {{ link.value.get_title }}
</a>

Steps to reproduce

1. Open the site on a mobile viewport (or resize browser < 768px)
2. Click the hamburger menu
3. Click any navigation link
4. You stay on the same page

Additional information

No response

Can be reproduced

Yes, on a fresh Wagtail project

Technical details

• Python version: Run python --version.
• Django version: Look in your requirements.txt, or run pip show django | grep Version.
• Wagtail version: Look at the bottom of the Settings menu in the Wagtail admin, or run pip show wagtail | grep Version:.
• Browser version: You can use https://www.whatsmybrowser.org/ to find this out.

Working on this

If you would like to contribute to this issue, follow these steps:

• Confirm that the issue is reproducible, either on a fresh Wagtail project or the bakerydemo.
• Once confirmed, view our contributing guidelines, add a comment to the issue once you're ready to start.

[vanshaj2023]

Hi @vossisboss @thibaudcolas
I fixed the issue and raise the pr #101
Please check this.

Thanks.

[vossisboss]

@vanshaj2023 Thank you for your contribution!

Please note we are already getting notifications about issues and PRs. You don't need to use additional tags in comments to notify us about your contribution. It adds to notification noise.