Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation and distribution is not done correctly #375

Open
exoRift opened this issue Jun 27, 2023 · 2 comments
Open

Compilation and distribution is not done correctly #375

exoRift opened this issue Jun 27, 2023 · 2 comments
Assignees

Comments

@exoRift
Copy link

exoRift commented Jun 27, 2023

The compilation and distribution of this package for Typescript is not done properly.

I love this library and would love to use it, however, no .ts files should be shipped, it should only be .js and .d.ts files, but there is something wrong with the compilation flags and the proper declaration files are not created and the source code is shipped with what's generated.

This makes it so that cal-heatmap works in dev, but any time you try to create a production build (Like with NextJS, for example), it fails because the TS files get linted and are incorrect. (It's using the types from the TS files instead of assertive declaration files)

For now, I've compiled the project myself and have just hard-stuck it into my project, but this isn't a great resolution to this massive issue.

@wa0x6e
Copy link
Owner

wa0x6e commented Dec 25, 2023

Will take a closer look at that

@wa0x6e wa0x6e self-assigned this Jan 21, 2024
@wa0x6e
Copy link
Owner

wa0x6e commented Jan 21, 2024

Should be fixed in master, will proceed to more tests before releasing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants