-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report URL in "name" attribute (instead of "document") #59
Comments
@toddreifsteck if we wanted to align RT and NT in this regard, and report the URL in both.. is that something Edge would be able to align with? |
We should reach out to the various Analytics vendors who are part of the group as well as internal Analytics folks at our various companies. IE11 and Edge 12-15 currently have shipped with this name='document' behavior for Navigation Timing 2. Although I have no pushback on the value of this update, I have concerns about breaking this behavior given years of a shipping implementation. If we choose to make this change, we should be clear that we are potentially breaking existing web code and should have some due diligence. @spanicker Perhaps Chrome can ship with name==URL and add Telemetry for getEntriesByName('document') and access to the entry.name entry on NavigationTiming2 objects? |
/cc @nicjansma |
I agree that it makes more sense to have Note boomerang does not query for NT2 in the Perf Timeline -- we query I haven't seen anyone query for Telemetry to validate our assumptions is always good :) |
Unless web devs / Nic indicate that moving to URL improves usability significantly, I'm not sure it's worth the additional last minute drill for NT2, given that it'll take some time & effort to investigate the compatibility issue. |
I think it would be a requirement for fixing #37, since in that case you would want to know the actual URL of each redirect. |
@igrigorik if you want this for M57, please file a crbug and I'll try to get it pulled in to the release. |
@nicjansma yep, exactly. @spanicker we already have https://bugs.chromium.org/p/chromium/issues/detail?id=675039, do we need another one? Personally, I'd strongly prefer we make this change now, before we have to implementations in the wild.. |
I haven't yet seen anyone rely on If this change is made, I suggest the value of
|
There's a strong request to merge this in M57, see spec bug: w3c/navigation-timing#59 BUG=675039 Review-Url: https://codereview.chromium.org/2675973004 Cr-Commit-Position: refs/heads/master@{#448517}
Update NT2 name to be the requested URL instead of 'document' There's a strong request to merge this in M57, see spec bug: w3c/navigation-timing#59
There's a strong request to merge this in M57, see spec bug: w3c/navigation-timing#59 BUG=675039 Review-Url: https://codereview.chromium.org/2675973004 Cr-Commit-Position: refs/heads/master@{#448517}
… a strong request to merge this in M57, see spec bug: w3c/navigation-timing#59 BUG=675039 Review-Url: https://codereview.chromium.org/2675973004 Cr-Commit-Position: refs/heads/master@{#448517} (cherry picked from commit 0af62af) Review-Url: https://codereview.chromium.org/2686973002 . Cr-Commit-Position: refs/branch-heads/2987@{#397} Cr-Branched-From: ad51088-refs/heads/master@{#444943}
The other way around, we need to report the final URL (window.location.toString()), otherwise we'll be reporting wrong timestamps for the advertised URL in the future; we can't expose the original URL unless that response passes TAO opt-in.
|
Check back in 2~3 weeks. |
I came here from https://lists.w3.org/Archives/Public/public-test-infra/2017JanMar/0025.html Is it a correct reading of this issue that everyone can live with the proposed behavior, but want to see it proven web compatible before actually committing to the change? This is a fairly common situation, but does make things tricky with Chromium's new 2-way wpt sync. Will comment further on public-test-infra. |
@foolip That is the exact concern. @patrickkettner flagged so he is aware of this thread. |
NT2 "name" attribute is currently set to "document".
Should this be set to the URL instead (as in RT2) ?
Related discussion in: https://crbug.com/675039
The text was updated successfully, but these errors were encountered: