Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should text overflow be handled? #122

Open
tunetheweb opened this issue May 27, 2024 · 0 comments
Open

How should text overflow be handled? #122

tunetheweb opened this issue May 27, 2024 · 0 comments
Assignees

Comments

@tunetheweb
Copy link
Member

tunetheweb commented May 27, 2024

Look at these tests:

If you set the viewport size to 680 x 500 you can see the following:

  • For the first one the LCP size is based on the whole scroll height of the text element rather than just the visible amount.
  • For the second it's only the visible amount.
  • For the third it's the visible amount that would be visible on-screen (i.e., it's cut off by being out of the viewport and somewhere in between the first and second size).

I have trouble understanding the algorithm in these cases but wanted to check if the first and third scenarios are correct? i.e. should we consider the whole element size in this (including the non-visible scrollable area) or it should it only be the visible size?

If the former will try to document this better at https://web.dev/articles/lcp, if the latter this looks like a Chrome bug.

Firefox incidentally has the same size for all three tests so either way it seems we have an interop bug that could be better specified as to what is correct.

@clelland clelland self-assigned this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants