Skip to content

compaction: t0112, t0113 in LD 1.0 processing mode #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daenney opened this issue Apr 6, 2025 · 2 comments · May be fixed by #655
Open

compaction: t0112, t0113 in LD 1.0 processing mode #649

daenney opened this issue Apr 6, 2025 · 2 comments · May be fixed by #655

Comments

@daenney
Copy link

daenney commented Apr 6, 2025

I'm running into an issue with t0112 and t0113 in compaction. No specVersion or processingMode is specified for those tests, so I'm assuming they should pass in ld-1.0 and ld-1.1.

However, I can't get them to pass on 1.0.

For t0112, the context is:

{
  "@context": {
    "ex": "http://example.org/ns/",
    "prop": {
      "@id": "ex:prop",
      "@container": "@index",
      "@index": "ex:name"
    }
  }
}

For t0113, the context is:

{
  "@context": {
    "ex": "http://example.org/ns/",
    "prop": {
      "@id": "ex:prop",
      "@container": "@index",
      "@index": "http://example.org/ns/name"
    }
  }
}

When running in LD 1.0 mode, I get an "Invalid Term Definition", based on step 20.1 in Create Term:

If value contains the entry @index:

The way I'm reading that is that if a property definition has an @index entry, and we're in LD 1.0 mode we need to bail out. The definition of prop includes @index, so it can't pass?

Looking at the expansion tests, I don't think there's one where @index is set on a term in an @context that runs for LD 1.0.

gkellogg added a commit that referenced this issue Apr 22, 2025
…Version: 1.1` to not interfer with 1.0 development.

Fixes #649.
@gkellogg gkellogg linked a pull request Apr 22, 2025 that will close this issue
@gkellogg
Copy link
Member

You're correct that these should both be set to "specVersion": "json-ld-1.1" based on that clause.

This was probably not caught, as we don't expect developers to work towards a distinct "1.0" vs. "1.1" mode, but rather wanted to give a way for developer who were using the 1.0 test suite to filter out 1.1-specific tests (and for 1.1 developers to ignore specific 1.0 tests).

Fixed in #655.

@gkellogg gkellogg moved this to Testing in JSON-LD Management Apr 22, 2025
@daenney
Copy link
Author

daenney commented Apr 23, 2025

Brilliant, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Testing
Development

Successfully merging a pull request may close this issue.

2 participants