Specify the params API #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelgoto
approved these changes
Oct 2, 2024
Co-authored-by: Ted Thibodeau Jr <[email protected]>
bvandersloot-mozilla
approved these changes
Oct 8, 2024
yi-gu
approved these changes
Oct 8, 2024
elf-pavlik
approved these changes
Oct 8, 2024
|
Discussed at 8 October meeting [minutes to be linked]. Agreed to merge when reviews complete. |
I think we got all reviews complete. Can I merge this? Or is there anything else actionable here? |
I got the ack from @wseltzer to merge. Done. |
github-actions bot
added a commit
that referenced
this pull request
Oct 8, 2024
SHA: bfa0a09 Reason: push, by samuelgoto Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to mattdanielbrown/WebID
that referenced
this pull request
Oct 9, 2024
SHA: bfa0a09 Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
samuelgoto
reviewed
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: w3c-fedid/custom-requests#2
Preview | Diff