Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image offsets are compared with the min_texel_gather_offset device property as u64 instead of i32. #2504

Open
LukeP0WERS opened this issue Mar 23, 2024 · 1 comment

Comments

@LukeP0WERS
Copy link
Contributor

When I updated to the vulkano master branch I got this error:
create_info.stage.entry_point: an `OpImageSample*` or `OpImageFetch*` instruction is performed, but its `ConstOffset` image operand contains a value that is less than the `min_texel_offset` device limit
even though the min_texel_gather_offset for my device is -8 and all of my offsets are 0 or 1.

It should be comparing with i32 instead of u64 here:

if offset < properties.min_texel_offset as u64 {

@Rua
Copy link
Contributor

Rua commented Mar 23, 2024

A nice example of how evil as can be!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants